Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always call JOSM over http #267

Merged
merged 1 commit into from Oct 18, 2019

Conversation

@grischard
Copy link
Contributor

commented Sep 28, 2019

Https in JOSM is unreliable and will be dropped soon. See https://josm.openstreetmap.de/ticket/10033

All modern browsers support calling 127.0.0.1 over http even from https pages, per spec:

w3c/webappsec-mixed-content@349501c
https://w3c.github.io/webappsec-secure-contexts/#is-origin-trustworthy

JOSM's default behaviour is to run without https.

Openstreetmap.org itself also always calls JOSM over http.

Https in JOSM is unreliable and will be dropped soon. See https://josm.openstreetmap.de/ticket/10033

All modern browsers support calling 127.0.0.1 over http even from https pages, per spec:

w3c/webappsec-mixed-content@349501c
https://w3c.github.io/webappsec-secure-contexts/#is-origin-trustworthy

JOSM's default behaviour is to run without https.

Openstreetmap.org itself also always calls JOSM over http.
@joto

This comment has been minimized.

Copy link
Member

commented Sep 28, 2019

I have to test this, I always had problem with this.

@grischard

This comment has been minimized.

Copy link
Contributor Author

commented Sep 28, 2019

Thank you. If you click 'edit' on https://openstreetmap.org it's going to call localhost over plain http and port 8111 too, no matter what protocol you are accessing openstreetmap.org with, so I'm pretty confident it will work these days, which was maybe not the case a few years ago.

@don-vip

This comment has been minimized.

Copy link

commented Oct 7, 2019

@joto situation improved a lot 2 years ago when Firefox and Chrome supported mixed-content, see https://josm.openstreetmap.de/ticket/10033#comment:38 and comments after. Then Edge and IE followed. Today it works with every browser except Safari, as they don't follow W3C here.

@grischard

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

See also openstreetmap/openstreetmap-website#1707 for the discussion to do this on openstreetmap.org in 2017/2018.

@joto joto merged commit 635b696 into taginfo:master Oct 18, 2019
@joto

This comment has been minimized.

Copy link
Member

commented Oct 18, 2019

I have just tried this patch, but reverted it after it broke JOSM access in my Firefox 60. It seems there are still problems.

@grischard

This comment has been minimized.

Copy link
Contributor Author

commented Oct 19, 2019

I'm confused. I've just tested opening josm in http from https://openstreetmap.org and it works fine. We could try http://127.0.0.1 instead, that's the only difference I see.

@grischard

This comment has been minimized.

Copy link
Contributor Author

commented Oct 19, 2019

Yup, using 127.0.0.1 works. PR coming up.

@grischard grischard deleted the grischard:patch-1 branch Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.