New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash when reading flac file #308

Closed
nerijus opened this Issue Nov 14, 2013 · 9 comments

Comments

Projects
None yet
6 participants
@nerijus

nerijus commented Nov 14, 2013

tagreader.cpp from examples crashes on http://sat.lt/test.flac :

Program received signal SIGSEGV, Segmentation fault.
0x0000003440f49276 in __memcpy_ssse3_back () from /lib64/libc.so.6
(gdb) bt
#0 0x0000003440f49276 in __memcpy_ssse3_back () from /lib64/libc.so.6
#1 0x00007ffff7d568a2 in TagLib::ByteVector::replace(TagLib::ByteVector const&, TagLib::ByteVector const&) () from /lib64/libtag.so.1
#2 0x00007ffff7d28ac9 in TagLib::ID3v2::SynchData::decode(TagLib::ByteVector const&) ()

from /lib64/libtag.so.1
#3 0x00007ffff7d2817d in TagLib::ID3v2::FrameFactory::createFrame(TagLib::ByteVector const&, TagLib::ID3v2::Header*) const () from /lib64/libtag.so.1
#4 0x00007ffff7d2c68f in TagLib::ID3v2::Tag::parse(TagLib::ByteVector const&) ()

from /lib64/libtag.so.1
#5 0x00007ffff7d2c929 in TagLib::ID3v2::Tag::read() () from /lib64/libtag.so.1
#6 0x00007ffff7d2ca3b in TagLib::ID3v2::Tag::Tag(TagLib::File_, long, TagLib::ID3v2::FrameFactory const_) () from /lib64/libtag.so.1
#7 0x00007ffff7d5d2e4 in TagLib::FLAC::File::read(bool, TagLib::AudioProperties::ReadStyle) ()

from /lib64/libtag.so.1
#8 0x00007ffff7d5d620 in TagLib::FLAC::File::File(char const*, bool, TagLib::AudioProperties::ReadStyle) () from /lib64/libtag.so.1
#9 0x00007ffff7d85372 in TagLib::FileRef::create(char const*, bool, TagLib::AudioProperties::ReadStyle) () from /lib64/libtag.so.1
#10 0x00007ffff7d86036 in TagLib::FileRef::FileRef(char const*, bool, TagLib::AudioProperties::ReadStyle) () from /lib64/libtag.so.1
#11 0x000000000040173b in main ()

OS Fedora 19.

@sbooth

This comment has been minimized.

Show comment
Hide comment
@sbooth

sbooth Nov 14, 2013

Contributor

The test FLAC file works on branch taglib2 but crashes on master. I'm comparing the two ByteVector classes to narrow down the cause.

Contributor

sbooth commented Nov 14, 2013

The test FLAC file works on branch taglib2 but crashes on master. I'm comparing the two ByteVector classes to narrow down the cause.

@TsudaKageyu

This comment has been minimized.

Show comment
Hide comment
@TsudaKageyu

TsudaKageyu Nov 14, 2013

Contributor

I fixed the bug at #309. Thanks @nerijus and @sbooth.

Contributor

TsudaKageyu commented Nov 14, 2013

I fixed the bug at #309. Thanks @nerijus and @sbooth.

sbooth added a commit that referenced this issue Nov 14, 2013

Merge pull request #309 from TsudaKageyu/fix-replace
Rewrote ByteVector::replace() simpler (fix for the issue #308)
@tliron

This comment has been minimized.

Show comment
Hide comment
@tliron

tliron Apr 26, 2014

This fix is not part of TagLib 1.9.1, am I correct? Because the bug appears in Ubuntu 14.04, which has TagLib 1.9.1.

tliron commented Apr 26, 2014

This fix is not part of TagLib 1.9.1, am I correct? Because the bug appears in Ubuntu 14.04, which has TagLib 1.9.1.

@TsudaKageyu

This comment has been minimized.

Show comment
Hide comment
@TsudaKageyu

TsudaKageyu Apr 26, 2014

Contributor

Yes, this bug was reported after TagLib1.9.1 was released.

Contributor

TsudaKageyu commented Apr 26, 2014

Yes, this bug was reported after TagLib1.9.1 was released.

@tliron

This comment has been minimized.

Show comment
Hide comment
@tliron

tliron Apr 26, 2014

Thank you! Any suggestions for a temporary workaround? An application I am developing keeps crashing because of this.

tliron commented Apr 26, 2014

Thank you! Any suggestions for a temporary workaround? An application I am developing keeps crashing because of this.

@muesli

This comment has been minimized.

Show comment
Hide comment
@muesli

muesli Nov 18, 2014

Any chance we can see a 1.9.2 release anytime soon? We're getting plenty of crash reports referencing this.

muesli commented Nov 18, 2014

Any chance we can see a 1.9.2 release anytime soon? We're getting plenty of crash reports referencing this.

@TsudaKageyu

This comment has been minimized.

Show comment
Hide comment
@TsudaKageyu

TsudaKageyu Feb 18, 2015

Contributor

Already fixed. Should be closed.

Contributor

TsudaKageyu commented Feb 18, 2015

Already fixed. Should be closed.

@sbooth sbooth closed this Feb 18, 2015

@nerijus

This comment has been minimized.

Show comment
Hide comment
@nerijus

nerijus Feb 18, 2015

It is fixed, but not in a taglib release. The bug should not be closed, as it will be reported again.

nerijus commented Feb 18, 2015

It is fixed, but not in a taglib release. The bug should not be closed, as it will be reported again.

@lalinsky

This comment has been minimized.

Show comment
Hide comment
@lalinsky

lalinsky Feb 18, 2015

Member

We have a practice of closing issues when they are merged, not released.

Member

lalinsky commented Feb 18, 2015

We have a practice of closing issues when they are merged, not released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment