Support large files over 2GB #77

Merged
merged 1 commit into from Nov 4, 2012

Conversation

Projects
None yet
3 participants
Contributor

TsudaKageyu commented Oct 10, 2012

Added a capability of handing large files over 2GB.

Owner

lalinsky commented Oct 10, 2012

Hm, offset_t doesn't seem to be a standard type. Can't find any official information about it. I'd rather stick to the standard types, which seems to be off_t from sys/types.h.

Contributor

TsudaKageyu commented Oct 10, 2012

offset_t isn't a standard type. I defined it.
As you say, normally, off_t is good for the case like this. But off_t is 32-bit in VC++ and not suitable for handling lage files.

The solutions I've come up with are:

  1. Rename offset_t to some name not like standard types.
  2. Abandon offset_t and use long long or int64_t instead of offset_t.
Owner

lalinsky commented Oct 10, 2012

Ah, sorry, I missed the typedef. I guess it's ok as it is then.

Owner

scotchi commented Oct 10, 2012

If we're creating a typedef'ed type anyway, is there a reason to use the type_t convention?

Contributor

TsudaKageyu commented Oct 12, 2012

Somebody could suggest a better name for offset_t?

Owner

lalinsky commented Nov 4, 2012

Sorry this stayed open for so long. I do not have a suggestion for a better name, so I'll merge it. It's in the taglib2, so it can be still changed later.

lalinsky merged commit b01f45e into taglib:taglib2 Nov 4, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment