Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assume TDRC is an instance of TextIdentificationFrame #831

Merged
merged 1 commit into from Sep 30, 2017
Merged

Don't assume TDRC is an instance of TextIdentificationFrame #831

merged 1 commit into from Sep 30, 2017

Conversation

sbooth
Copy link
Contributor

@sbooth sbooth commented Jul 23, 2017

If TDRC is encrypted, FrameFactory::createFrame() returns UnknownFrame
which causes problems in rebuildAggregateFrames() when it is assumed
that TDRC is a TextIdentificationFrame

Fixes #829

If TDRC is encrypted, FrameFactory::createFrame() returns UnknownFrame
which causes problems in rebuildAggregateFrames() when it is assumed
that TDRC is a TextIdentificationFrame
@sbooth sbooth added the bug label Jul 23, 2017
@sbooth
Copy link
Contributor Author

sbooth commented Aug 12, 2017

Is this sufficient to fix #829 or should all uses of static_cast be replaced in the event a frame is encrypted?

@sbooth sbooth merged commit cb9f07d into taglib:master Sep 30, 2017
@sbooth sbooth deleted the encrypted-tdrc-crash branch September 30, 2017 15:15
ufleisch pushed a commit to ufleisch/taglib that referenced this pull request Dec 31, 2020
If TDRC is encrypted, FrameFactory::createFrame() returns UnknownFrame
which causes problems in rebuildAggregateFrames() when it is assumed
that TDRC is a TextIdentificationFrame
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant