New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist sort order of list / tag grouping #165

Closed
ghost opened this Issue Nov 26, 2014 · 12 comments

Comments

Projects
None yet
1 participant
@ghost

ghost commented Nov 26, 2014

After closing and opening the application, the sort order of a list view is lost. It would be great if that could persist across sessions. The same holds for the groupingby tag of the grid view.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jan 12, 2015

There is now a $50 bounty for this.

ghost commented Jan 12, 2015

There is now a $50 bounty for this.

claell added a commit to claell/tagspaces that referenced this issue Jan 12, 2015

@uggrock uggrock closed this in #183 Jan 14, 2015

uggrock added a commit that referenced this issue Jan 14, 2015

Merge pull request #183 from claell/patch-1
Fixing a typo and hopefully issue #165
@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jan 15, 2015

I just tried out the latest git and the issue does not seem to be fixed.

To reproduce either

  • add a new folder with default list view
  • sort by date
  • close app
  • reopen app
  • sort order is lost

or

  • add a new folder with default grid view
  • group by day
  • close app
  • reopen app
  • grouping is lost

ghost commented Jan 15, 2015

I just tried out the latest git and the issue does not seem to be fixed.

To reproduce either

  • add a new folder with default list view
  • sort by date
  • close app
  • reopen app
  • sort order is lost

or

  • add a new folder with default grid view
  • group by day
  • close app
  • reopen app
  • grouping is lost
@claell

This comment has been minimized.

Show comment
Hide comment
@claell

claell Jan 15, 2015

Contributor

I am sorry to hear this. It works for me with github version and Node Webkit on Ubuntu.

Did you followed the tutorial "How to run TagSpaces from the source code?"?:

How to run TagSpaces from the source code?

Get the TagSpaces source code by cloning its repository:

$git clone https://github.com/tagspaces/tagspaces.git

Run as native Windows, Linux or Mac OS X application

  • Download node-webkit prebuilt binaries for your system environment.
    • For Windows: copy nw.exe, nw.pak, icudt.dll, ffmpegsumo.dll to tagspaces/data/node-webkit directory.
    • For Linux: copy nw, nw.pak, icudtl.dat, libffmpegsumo.so to tagspaces/data/node-webkit directory. If you experience issue related to libudev.so.0 read the following article.
    • For Mac OS X: copy node-webkit.app to tagspaces/data/node-webkit directory.
  • Run the nw executable file.

But: I only added support for saving to list view. Nevertheless, the first usecase should work for you.

Contributor

claell commented Jan 15, 2015

I am sorry to hear this. It works for me with github version and Node Webkit on Ubuntu.

Did you followed the tutorial "How to run TagSpaces from the source code?"?:

How to run TagSpaces from the source code?

Get the TagSpaces source code by cloning its repository:

$git clone https://github.com/tagspaces/tagspaces.git

Run as native Windows, Linux or Mac OS X application

  • Download node-webkit prebuilt binaries for your system environment.
    • For Windows: copy nw.exe, nw.pak, icudt.dll, ffmpegsumo.dll to tagspaces/data/node-webkit directory.
    • For Linux: copy nw, nw.pak, icudtl.dat, libffmpegsumo.so to tagspaces/data/node-webkit directory. If you experience issue related to libudev.so.0 read the following article.
    • For Mac OS X: copy node-webkit.app to tagspaces/data/node-webkit directory.
  • Run the nw executable file.

But: I only added support for saving to list view. Nevertheless, the first usecase should work for you.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jan 15, 2015

Yes, I did follow these exact instructions, also under Ubuntu, using the Github version.

I can verify that state persists when changing between directories. But when I close the app and re-start it, the sort order of the list-view is reset to sort by name, ascending.

ghost commented Jan 15, 2015

Yes, I did follow these exact instructions, also under Ubuntu, using the Github version.

I can verify that state persists when changing between directories. But when I close the app and re-start it, the sort order of the list-view is reset to sort by name, ascending.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jan 15, 2015

Anyway, the bug should be understood to also cover the grid view. I imagine that the solution would be similar there.

ghost commented Jan 15, 2015

Anyway, the bug should be understood to also cover the grid view. I imagine that the solution would be similar there.

@claell

This comment has been minimized.

Show comment
Hide comment
@claell

claell Jan 15, 2015

Contributor

I will try a new installation as well as a Virtual PC with Ubuntu.

The solution for grid view is alot different afaik, but I can try to do it as well.

Contributor

claell commented Jan 15, 2015

I will try a new installation as well as a Virtual PC with Ubuntu.

The solution for grid view is alot different afaik, but I can try to do it as well.

@claell

This comment has been minimized.

Show comment
Hide comment
@claell

claell Jan 15, 2015

Contributor

Just tried a new installation, but it still works. I am using 64bit. Are you using 32 bit?

Contributor

claell commented Jan 15, 2015

Just tried a new installation, but it still works. I am using 64bit. Are you using 32 bit?

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jan 15, 2015

Sorry for the hassle. No, I am also on 64 bit. I'll try it over the weekend on a different computer, maybe it's some weird feature of my setup.

ghost commented Jan 15, 2015

Sorry for the hassle. No, I am also on 64 bit. I'll try it over the weekend on a different computer, maybe it's some weird feature of my setup.

@claell

This comment has been minimized.

Show comment
Hide comment
@claell

claell Jan 15, 2015

Contributor

No problem. Might be really be caused by your setup. I guess that @uggrock tested my pull request.

Regarding to the group view, found out that the grouping is switched with this function:

ExtUI.prototype.switchGrouping = function(grouping) {
        this.currentGrouping = grouping;
        //TSCORE.startTime = new Date().getTime(); 
        this.reInit();
    };

Unfortunately I do not know, how to store this new grouping so it can be read out and set again after a restart.

Contributor

claell commented Jan 15, 2015

No problem. Might be really be caused by your setup. I guess that @uggrock tested my pull request.

Regarding to the group view, found out that the grouping is switched with this function:

ExtUI.prototype.switchGrouping = function(grouping) {
        this.currentGrouping = grouping;
        //TSCORE.startTime = new Date().getTime(); 
        this.reInit();
    };

Unfortunately I do not know, how to store this new grouping so it can be read out and set again after a restart.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jan 16, 2015

Hi, can confirm this now fixed on 10.1 (now, the previous folder isn't automatically opened on start anymore, but that's a different issue...). Thanks for your work!

I'll open a new issue for the grid perspective. Of course, any contribution there would be immensely helpful.

ghost commented Jan 16, 2015

Hi, can confirm this now fixed on 10.1 (now, the previous folder isn't automatically opened on start anymore, but that's a different issue...). Thanks for your work!

I'll open a new issue for the grid perspective. Of course, any contribution there would be immensely helpful.

@claell

This comment has been minimized.

Show comment
Hide comment
@claell

claell Jan 16, 2015

Contributor

Ok, glad that it works for you now. For me the previous folder is opened automatically at start, afaik.

Will see, what I can do for grid, but maybe @uggrock will find time to help as he knows better how to do JS.

Contributor

claell commented Jan 16, 2015

Ok, glad that it works for you now. For me the previous folder is opened automatically at start, afaik.

Will see, what I can do for grid, but maybe @uggrock will find time to help as he knows better how to do JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment