New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown font size should be improved or be customisable #27

Closed
brevilo opened this Issue Feb 25, 2014 · 8 comments

Comments

Projects
None yet
3 participants
@brevilo

brevilo commented Feb 25, 2014

The standard Markdown font size for regular text is way too small - at least on OS X. While the font sizes for headings are fine, the regular font is rendered at about 6-8 points in 1.7.4. You could either make the font sizes fully customisable or allow to define a minimum font size, both as part of the preferences.

Thanks

@uggrock uggrock added this to the v1.7.5 milestone Feb 26, 2014

@uggrock

This comment has been minimized.

Show comment
Hide comment
@uggrock

uggrock Feb 26, 2014

Member

issue is fixed in the upcoming 1.7.5 release

Member

uggrock commented Feb 26, 2014

issue is fixed in the upcoming 1.7.5 release

@uggrock uggrock closed this Feb 26, 2014

@brevilo

This comment has been minimized.

Show comment
Hide comment
@brevilo

brevilo Feb 26, 2014

I suppose because of this commit (despite it referencing a different, seemingly unrelated issue): 953449c

Thanks

brevilo commented Feb 26, 2014

I suppose because of this commit (despite it referencing a different, seemingly unrelated issue): 953449c

Thanks

@uggrock

This comment has been minimized.

Show comment
Hide comment
@uggrock

uggrock Feb 26, 2014

Member

yes, you are right, I must have switched #27 with #23 in the commit. Now the markdown files appear much nicer.
image

Member

uggrock commented Feb 26, 2014

yes, you are right, I must have switched #27 with #23 in the commit. Now the markdown files appear much nicer.
image

@brevilo

This comment has been minimized.

Show comment
Hide comment
@brevilo

brevilo Feb 26, 2014

Indeed! And besides that, now I know where to customise things if I still want to ;-)

Thanks!

brevilo commented Feb 26, 2014

Indeed! And besides that, now I know where to customise things if I still want to ;-)

Thanks!

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Feb 27, 2014

Collaborator

If you wish, you can take a look on the corrected MD viewer and the improved HTML editor under: https://github.com/uggrock/tagspaces/releases/tag/v1.7.5

Collaborator

ghost commented Feb 27, 2014

If you wish, you can take a look on the corrected MD viewer and the improved HTML editor under: https://github.com/uggrock/tagspaces/releases/tag/v1.7.5

@brevilo

This comment has been minimized.

Show comment
Hide comment
@brevilo

brevilo Feb 28, 2014

The regular font size looks much better now. However the relative font sizes of H1, H2, H3 and H4 (in particular of H3) are not yet fully proportional. Just use the following to see:

# first
## second
### third
#### fourth

regular

H3 seems to be of the same size as H1 and H4 seems to have the same size as H2. I'd expect them to continuously decrease in size.

Also, all six sizes H1-H6 should be supported.

brevilo commented Feb 28, 2014

The regular font size looks much better now. However the relative font sizes of H1, H2, H3 and H4 (in particular of H3) are not yet fully proportional. Just use the following to see:

# first
## second
### third
#### fourth

regular

H3 seems to be of the same size as H1 and H4 seems to have the same size as H2. I'd expect them to continuously decrease in size.

Also, all six sizes H1-H6 should be supported.

@brevilo

This comment has been minimized.

Show comment
Hide comment
@brevilo

brevilo Feb 28, 2014

I think there's a regression: upon saving the editor introduces a little red round dot at the start of the first line which breaks the markdown in that line (e.g. a heading).

brevilo commented Feb 28, 2014

I think there's a regression: upon saving the editor introduces a little red round dot at the start of the first line which breaks the markdown in that line (e.g. a heading).

@uggrock

This comment has been minimized.

Show comment
Hide comment
@uggrock

uggrock Feb 28, 2014

Member

thank you, for the remarks! Both of them are fixed for the next release. The little red dot is needed for the UTF8 support. It actually should not showed by codemirror. I hope this is fixed in the newer codemirror releases.

Member

uggrock commented Feb 28, 2014

thank you, for the remarks! Both of them are fixed for the next release. The little red dot is needed for the UTF8 support. It actually should not showed by codemirror. I hope this is fixed in the newer codemirror releases.

uggrock added a commit that referenced this issue Feb 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment