Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to flake8 as a better way of running pyflakes. #736

Merged
merged 1 commit into from Jul 6, 2020

Conversation

itamarst
Copy link
Collaborator

@itamarst itamarst commented Jul 6, 2020

Fixes ticket:3329

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2020

Codecov Report

Merging #736 into master will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #736      +/-   ##
==========================================
+ Coverage   90.73%   90.89%   +0.15%     
==========================================
  Files         155      155              
  Lines       27267    27267              
  Branches     3893     3893              
==========================================
+ Hits        24741    24784      +43     
+ Misses       1823     1783      -40     
+ Partials      703      700       -3     
Impacted Files Coverage Δ
src/allmydata/mutable/publish.py 96.66% <0.00%> (+1.01%) ⬆️
src/allmydata/immutable/downloader/share.py 95.29% <0.00%> (+2.46%) ⬆️
src/allmydata/control.py 68.72% <0.00%> (+5.28%) ⬆️
src/allmydata/version_checks.py 69.58% <0.00%> (+5.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd24b9...906d6ac. Read the comment docs.

Copy link
Contributor

@meejah meejah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
👍

@itamarst itamarst merged commit 10f2b7f into master Jul 6, 2020
@itamarst itamarst deleted the 3329-flake8 branch July 6, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants