Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zfec wheel package from testpypi #804

Closed
wants to merge 7 commits into from

Conversation

sajith
Copy link
Member

@sajith sajith commented Sep 11, 2020

Testing that Tahoe-LAFS can use zfec wheel packages.

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2020

Codecov Report

Merging #804 into master will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #804    +/-   ##
=======================================
- Coverage      92%     91%    -0%     
=======================================
  Files         155     155            
  Lines       27355   27355            
  Branches     4099    3896   -203     
=======================================
- Hits        25138   25011   -127     
- Misses       1534    1601    +67     
- Partials      683     743    +60     
Impacted Files Coverage Δ
src/allmydata/util/humanreadable.py 65% <0%> (-16%) ⬇️
src/allmydata/crypto/__init__.py 86% <0%> (-14%) ⬇️
src/allmydata/crypto/error.py 89% <0%> (-11%) ⬇️
src/allmydata/util/_python3.py 89% <0%> (-11%) ⬇️
src/allmydata/storage/common.py 89% <0%> (-11%) ⬇️
src/allmydata/util/assertutil.py 89% <0%> (-11%) ⬇️
src/allmydata/web/common_py3.py 82% <0%> (-9%) ⬇️
src/allmydata/crypto/util.py 92% <0%> (-8%) ⬇️
src/allmydata/util/mathutil.py 92% <0%> (-8%) ⬇️
src/allmydata/util/base32.py 93% <0%> (-7%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e1223...58638ca. Read the comment docs.

@sajith sajith mentioned this pull request Sep 17, 2020
10 tasks
@sajith sajith mentioned this pull request Oct 15, 2020
@sajith
Copy link
Member Author

sajith commented Nov 16, 2020

Closing, because this was meant to be an experimental branch to test if zfec wheel packages can actually work without having to install vcpython27 on Windows. This is superseded by PR #862 which uses zfec from pypi.org.

@sajith sajith closed this Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants