Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce vcpython27 in GitHub Actions #909

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

sajith
Copy link
Member

@sajith sajith commented Nov 25, 2020

Fix for 3537.

I broke the CI when I merged #862: Turns out that netifaces has not published a .whl package for Python 2.7 and 64-bit Windows, so we will need vcpython27 after all. PR branch for #862 was older than from the time netifaces was added, so I missed it when testing.

Sorry. :-(

Turns out that netifaces has not published a .whl package for Python
2.7 and 64-bit Windows.
@sajith
Copy link
Member Author

sajith commented Nov 25, 2020

Related issue: al45tair/netifaces/issues/47

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #909 (c8aab08) into master (4e5eb13) will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #909    +/-   ##
=======================================
- Coverage      92%     91%    -0%     
=======================================
  Files         158     158            
  Lines       27609   27609            
  Branches     4136    3933   -203     
=======================================
- Hits        25306   25261    -45     
+ Misses       1636    1575    -61     
- Partials      667     773   +106     
Impacted Files Coverage Δ
src/allmydata/util/dictutil.py 79% <0%> (-21%) ⬇️
src/allmydata/util/humanreadable.py 65% <0%> (-16%) ⬇️
src/allmydata/_monkeypatch.py 86% <0%> (-14%) ⬇️
src/allmydata/crypto/__init__.py 86% <0%> (-14%) ⬇️
src/allmydata/immutable/downloader/__init__.py 86% <0%> (-14%) ⬇️
src/allmydata/storage/common.py 88% <0%> (-12%) ⬇️
src/allmydata/crypto/error.py 89% <0%> (-11%) ⬇️
src/allmydata/util/_python3.py 89% <0%> (-11%) ⬇️
src/allmydata/util/assertutil.py 89% <0%> (-11%) ⬇️
src/allmydata/crypto/util.py 92% <0%> (-8%) ⬇️
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e5eb13...c8aab08. Read the comment docs.

Copy link
Member

@exarkun exarkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Sorry I didn't catch this one in review! Please merge.

@sajith sajith merged commit 5565192 into tahoe-lafs:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants