Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[error] [doc] Better error message when X11 environment failed to initialize #1856

Merged
merged 7 commits into from Sep 14, 2020

Conversation

archibate
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #1856 into master will increase coverage by 0.95%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1856      +/-   ##
==========================================
+ Coverage   43.25%   44.21%   +0.95%     
==========================================
  Files          44       44              
  Lines        6320     6111     -209     
  Branches     1092     1092              
==========================================
- Hits         2734     2702      -32     
+ Misses       3416     3240     -176     
+ Partials      170      169       -1     
Impacted Files Coverage Δ
python/taichi/lang/ast_checker.py 70.58% <0.00%> (-1.64%) ⬇️
python/taichi/testing.py 75.00% <0.00%> (-0.72%) ⬇️
python/taichi/lang/linalg.py 89.33% <0.00%> (-0.67%) ⬇️
python/taichi/lang/meta.py 62.31% <0.00%> (-0.54%) ⬇️
python/taichi/lang/__init__.py 41.94% <0.00%> (-0.51%) ⬇️
python/taichi/misc/util.py 17.48% <0.00%> (-0.26%) ⬇️
python/taichi/misc/task.py 0.00% <0.00%> (ø)
python/taichi/lang/shell.py 0.00% <0.00%> (ø)
python/taichi/tools/patterns.py 0.00% <0.00%> (ø)
python/taichi/lang/kernel.py 71.17% <0.00%> (+0.13%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbbef94...15303c9. Read the comment docs.

Copy link
Contributor

@thinking-tower thinking-tower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for moving the fps stuff!

@archibate archibate added the LGTM label Sep 11, 2020
@archibate
Copy link
Collaborator Author

All required statuses and check runs on this pull request must run successfully to enable automatic merging.

@yuanming-hu Can we use an or parse in this 'required statuses` mechanism? I.e.

(Build and Test && Code format) || Checks the Workflow Run of the Previous Commit

LHS for non-gardener final-commit, RS for gardener final-commit, which always fix the code format.

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Just one wording nit.

@yuanming-hu Can we use an or parse in this 'required statuses` mechanism? I.e.

(Build and Test && Code format) || Checks the Workflow Run of the Previous Commit

LHS for non-gardener final-commit, RS for gardener final-commit, which always fix the code format.

GitHub doesn't provide that option, unfortunately...

docs/gui.rst Outdated Show resolved Hide resolved
Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
@archibate archibate merged commit 42b05e4 into taichi-dev:master Sep 14, 2020
@yuanming-hu yuanming-hu mentioned this pull request Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants