New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .gitdata.listRefs instead of .gitdata.getTags #103

Merged
merged 1 commit into from Jan 21, 2019

Conversation

Projects
None yet
2 participants
@hatappi
Copy link
Contributor

hatappi commented Jan 18, 2019

WHAT

  • when getTags, use .gitdata.listRefs instead of .gitdata.getTags

WHY

I use v0.7.3, but error occured.

TypeError: github.gitdata.getTags is not a function
    at selectGetTagsPromise (/usr/local/share/.config/yarn/global/node_modules/ci-yarn-upgrade/lib/github.js:107:48)
    at reconcile (/usr/local/share/.config/yarn/global/node_modules/ci-yarn-upgrade/lib/github.js:132:44)
    at data.children.map.e (/usr/local/share/.config/yarn/global/node_modules/ci-yarn-upgrade/lib/github.js:146:41)
    at Array.map (<anonymous>)
    at then.data (/usr/local/share/.config/yarn/global/node_modules/ci-yarn-upgrade/lib/github.js:146:32)
    at process._tickCallback (internal/process/next_tick.js:68:7)
Exited with code 1

The cause is @octokit/rest version.
ci-yarn-upgrade current use @octokit/rest@16.9.0.
But .gitdata.getTags remove since v16.0.1
ref. https://github.com/octokit/rest.js/releases/tag/v16.0.1

I use .gitdata.listRefs instead.
https://octokit.github.io/rest.js/#api-Git-listRefs

@hatappi

This comment has been minimized.

Copy link
Contributor Author

hatappi commented Jan 18, 2019

@taichi
Hello!
Please check my pull requests 🙏
But CI has been waiting status forever 😢

@taichi taichi merged commit 6049bec into taichi:master Jan 21, 2019

1 check passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details

@hatappi hatappi deleted the hatappi:use-listRefs branch Jan 21, 2019

@taichi

This comment has been minimized.

Copy link
Owner

taichi commented Jan 21, 2019

I just released 0.7.5.
please check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment