From 0ba1a6b9e8be29f3098e7d4643152c8b83da5291 Mon Sep 17 00:00:00 2001 From: Taiki Endo Date: Fri, 26 Apr 2024 17:30:34 +0900 Subject: [PATCH] Update actions/cache from 3 to 4 --- .github/workflows/ci.yml | 6 ++---- CHANGELOG.md | 4 ++++ README.md | 2 +- action.yml | 3 +-- 4 files changed, 8 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ac5211e..83f2662 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -92,7 +92,6 @@ jobs: fail-fast: false matrix: container: - - ubuntu:18.04 # glibc 2.27 - ubuntu:20.04 # glibc 2.31 - ubuntu:22.04 # glibc 2.35 - ubuntu:24.04 # glibc 2.39 @@ -104,7 +103,6 @@ jobs: - almalinux:8-minimal # glibc 2.28 - almalinux:9 # glibc 2.34 - almalinux:9-minimal # glibc 2.34 - - centos:7 # glibc 2.17 - archlinux:latest # glibc 2.38 (as of 2024-04-18) - alpine:latest # musl 1.2.4 (as of alpine 3.19) runs-on: ubuntu-latest @@ -120,7 +118,7 @@ jobs: echo "$HOME/.cargo/bin" >>"${GITHUB_PATH}" apt-get -qq -o Dpkg::Use-Pty=0 remove -y curl if: startsWith(matrix.container, 'ubuntu') || startsWith(matrix.container, 'debian') - - name: Install requirements (fedora/almalinux/centos) + - name: Install requirements (fedora/almalinux) run: | set -eEuxo pipefail if type -P dnf &>/dev/null; then @@ -132,7 +130,7 @@ jobs: fi curl --proto '=https' --tlsv1.2 -fsSL --retry 10 https://sh.rustup.rs | sh -s -- -y --profile minimal --default-toolchain stable --no-modify-path echo "$HOME/.cargo/bin" >>"${GITHUB_PATH}" - if: startsWith(matrix.container, 'fedora') || startsWith(matrix.container, 'almalinux') || startsWith(matrix.container, 'centos') + if: startsWith(matrix.container, 'fedora') || startsWith(matrix.container, 'almalinux') - name: Install requirements (archlinux) run: pacman -Sy --noconfirm rust if: startsWith(matrix.container, 'archlinux') diff --git a/CHANGELOG.md b/CHANGELOG.md index daff538..a0e2791 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,10 @@ Note: In this file, do not use the hard wrap in the middle of a sentence for com ## [Unreleased] +- Update `actions/cache` from 3 to 4. + + This [breaks compatibility with CentOS 7 and Ubuntu 18.04](https://github.com/actions/runner/issues/2906) so it is treated as a breaking change. + ## [1.4.0] - 2024-04-26 - Improve support for Arch based containers/self-hosted runners. diff --git a/README.md b/README.md index 8d4f19e..5e558bf 100644 --- a/README.md +++ b/README.md @@ -109,7 +109,7 @@ The interface of this action is a subset of the interface of [install-action], s ## Compatibility -This action has been tested for GitHub-hosted runners (Ubuntu, macOS, Windows) and containers (Ubuntu, Debian, Fedora, CentOS, Alma, Arch, Alpine). +This action has been tested for GitHub-hosted runners (Ubuntu, macOS, Windows) and containers (Ubuntu, Debian, Fedora, Alma, Arch, Alpine). To use this action in self-hosted runners or in containers, at least the following tools are required: - bash diff --git a/action.yml b/action.yml index acea592..70cd0ce 100644 --- a/action.yml +++ b/action.yml @@ -40,8 +40,7 @@ runs: INPUT_REV: ${{ inputs.rev }} - name: Restore Cache id: cache - # TODO: currently, we cannot update to v4 because node20 doesn't work on CentOS 7: https://github.com/actions/runner/issues/2906 - uses: actions/cache@v3 + uses: actions/cache@v4 with: path: ${{ steps.pre.outputs.path }} key: ${{ steps.pre.outputs.key }}