Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add xh #512

Merged
merged 3 commits into from
Jun 8, 2024
Merged

Add xh #512

merged 3 commits into from
Jun 8, 2024

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Jun 8, 2024 •
edited

https://github.com/ducaale/xh , curl /httpie clone

@jayvdb jayvdb marked this pull request as ready for review June 8, 2024 02:06
NobodyXu
NobodyXu reviewed Jun 8, 2024
View reviewed changes
Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want a curl clone in this action?
Don't we already have curl?

@NobodyXu
Copy link
Collaborator

NobodyXu commented Jun 8, 2024

I have a similar complaint #513 (review) , really don't think we should support everything here.

NobodyXu
NobodyXu approved these changes Jun 8, 2024
View reviewed changes
Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

xh seems quite useful, while curl is enough for many scripts, xh is quite useful for testing restful APIs and a good alternative to httpie

@NobodyXu NobodyXu merged commit df5666f into taiki-e:main Jun 8, 2024
29 checks passed
@jayvdb jayvdb deleted the xh branch June 8, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NobodyXu NobodyXu NobodyXu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jayvdb @NobodyXu