Skip to content

feat: enable POST requests batching with dl.#3140

Merged
tusharmath merged 47 commits into
mainfrom
feat/impl-body-batching-with-dl
Dec 10, 2024
Merged

feat: enable POST requests batching with dl.#3140
tusharmath merged 47 commits into
mainfrom
feat/impl-body-batching-with-dl

Conversation

@laststylebender14

@laststylebender14 laststylebender14 commented Nov 23, 2024

Copy link
Copy Markdown
Contributor

Summary:
docs: tailcallhq/tailcallhq.github.io#559

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions Bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Nov 23, 2024
@codecov

codecov Bot commented Nov 23, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 94.58204% with 35 lines in your changes missing coverage. Please review.

Project coverage is 86.78%. Comparing base (626b142) to head (b8ce74a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/ir/request.rs 62.50% 9 Missing ⚠️
src/core/json/borrow.rs 0.00% 6 Missing ⚠️
src/core/json/serde.rs 0.00% 6 Missing ⚠️
src/core/http/data_loader_request.rs 80.00% 4 Missing ⚠️
src/core/json/graphql.rs 50.00% 3 Missing ⚠️
src/core/blueprint/operators/http.rs 96.77% 2 Missing ⚠️
src/core/http/data_loader.rs 96.66% 2 Missing ⚠️
src/core/http/request_template.rs 97.84% 2 Missing ⚠️
src/core/ir/eval_http.rs 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3140      +/-   ##
==========================================
+ Coverage   86.66%   86.78%   +0.12%     
==========================================
  Files         278      281       +3     
  Lines       27924    28435     +511     
==========================================
+ Hits        24201    24678     +477     
- Misses       3723     3757      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread src/core/http/data_loader.rs Outdated
@tusharmath tusharmath marked this pull request as draft November 28, 2024 19:22
@github-actions

github-actions Bot commented Dec 4, 2024

Copy link
Copy Markdown

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions Bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Dec 4, 2024
Comment thread src/core/blueprint/operators/http.rs Outdated
@laststylebender14 laststylebender14 marked this pull request as ready for review December 9, 2024 07:54
Comment thread .github/workflows/ci.yml
@tusharmath tusharmath merged commit f067629 into main Dec 10, 2024
@tusharmath tusharmath deleted the feat/impl-body-batching-with-dl branch December 10, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feature Brand new functionality, features, pages, workflows, endpoints, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants