Skip to content

refactor: use links only from the root config#3190

Merged
tusharmath merged 3 commits intomainfrom
refactor/link-merging
Dec 10, 2024
Merged

refactor: use links only from the root config#3190
tusharmath merged 3 commits intomainfrom
refactor/link-merging

Conversation

@meskill
Copy link
Contributor

@meskill meskill commented Dec 3, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Phase 1 of #3164

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Dec 3, 2024
@codecov
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 97.87234% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.78%. Comparing base (f067629) to head (6e94ef2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/core/config/reader.rs 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3190      +/-   ##
==========================================
- Coverage   86.78%   86.78%   -0.01%     
==========================================
  Files         281      281              
  Lines       28435    28443       +8     
==========================================
+ Hits        24678    24684       +6     
- Misses       3757     3759       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Dec 9, 2024

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Dec 9, 2024
@meskill meskill marked this pull request as ready for review December 10, 2024 10:17
@tusharmath tusharmath merged commit 0f3721b into main Dec 10, 2024
@tusharmath tusharmath deleted the refactor/link-merging branch December 10, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: chore Routine tasks like conversions, reorganization, and maintenance work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants