Skip to content

fix: tailcall generation schema for non required fields#3202

Merged
tusharmath merged 1 commit intomainfrom
fix/tailcall-graphql-schema
Dec 6, 2024
Merged

fix: tailcall generation schema for non required fields#3202
tusharmath merged 1 commit intomainfrom
fix/tailcall-graphql-schema

Conversation

@meskill
Copy link
Copy Markdown
Contributor

@meskill meskill commented Dec 6, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions Bot added the type: fix Iterations on existing features or infrastructure. label Dec 6, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.73%. Comparing base (6ca5788) to head (b771a41).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
tailcall-typedefs-common/src/input_definition.rs 84.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3202      +/-   ##
==========================================
- Coverage   86.73%   86.73%   -0.01%     
==========================================
  Files         278      278              
  Lines       27914    27918       +4     
==========================================
+ Hits        24211    24214       +3     
- Misses       3703     3704       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tusharmath tusharmath merged commit b16cd3d into main Dec 6, 2024
@tusharmath tusharmath deleted the fix/tailcall-graphql-schema branch December 6, 2024 17:32
@tusharmath
Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix Iterations on existing features or infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants