Skip to content

chore: cleanup json/yaml support for cli#3217

Merged
tusharmath merged 2 commits into
mainfrom
chore/cleanup-format
Dec 9, 2024
Merged

chore: cleanup json/yaml support for cli#3217
tusharmath merged 2 commits into
mainfrom
chore/cleanup-format

Conversation

@meskill
Copy link
Copy Markdown
Contributor

@meskill meskill commented Dec 9, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions Bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Dec 9, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.66%. Comparing base (01ebf87) to head (d4eb96b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/cli/tc/run.rs 0.00% 2 Missing ⚠️
src/cli/generator/generator.rs 0.00% 1 Missing ⚠️
src/cli/tc/check.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3217   +/-   ##
=======================================
  Coverage   86.66%   86.66%           
=======================================
  Files         278      278           
  Lines       27932    27924    -8     
=======================================
- Hits        24206    24201    -5     
+ Misses       3726     3723    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tusharmath tusharmath merged commit 626b142 into main Dec 9, 2024
@tusharmath tusharmath deleted the chore/cleanup-format branch December 9, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: chore Routine tasks like conversions, reorganization, and maintenance work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants