fix(core): Address UTF-8 character boundary issues in LineBreaker#3228
Merged
tusharmath merged 5 commits intoDec 26, 2024
Merged
Conversation
Contributor
|
Thanks @iamchanii 🙌 |
tusharmath
approved these changes
Dec 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3228 +/- ##
==========================================
+ Coverage 86.30% 86.32% +0.01%
==========================================
Files 282 282
Lines 28761 28798 +37
==========================================
+ Hits 24823 24860 +37
Misses 3938 3938 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR integrates the
unicode-segmentationcrate to address issues related to UTF-8 character boundaries in theLineBreakerstruct. The changes ensure that string documentation is formatted safely without encountering byte index errors. The code now correctly iterates over grapheme clusters, thus maintaining valid character boundaries during string manipulation.Before the change, the added test case causes a panic.
Issue Reference(s):
N/A
Build & Testing:
cargo testsuccessfully../lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check.Checklist:
<type>(<optional scope>): <title>