util/uniq: add new package #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josharian
force-pushed
the
josh/uniq-slice
branch
from
12d9e49
to
c0ea0c5
Compare
|
We don't really need this, but I always screw up the linear compaction thing, and it was fun to build. |
bradfitz
reviewed
Oct 1, 2020
bradfitz
reviewed
Oct 1, 2020
josharian
force-pushed
the
josh/uniq-slice
branch
from
c0ea0c5
to
13c39b7
Compare
|
PTAL |
bradfitz
reviewed
Oct 1, 2020
bradfitz
reviewed
Oct 1, 2020
josharian
force-pushed
the
josh/uniq-slice
branch
4 times, most recently
from
b170a6c
to
79295c3
Compare
bradfitz
reviewed
Oct 2, 2020
bradfitz
reviewed
Oct 2, 2020
bradfitz
approved these changes
Oct 2, 2020
crawshaw
approved these changes
Oct 2, 2020
This makes it easy to compact slices that contain duplicate elements by sorting and then uniqing. This is an alternative to constructing an intermediate map and then extracting elements from it. It also provides more control over equality than using a map key does. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
josharian
force-pushed
the
josh/uniq-slice
branch
from
79295c3
to
ea50f3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is