Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugins to source their config themselves #696

Merged
merged 64 commits into from Feb 28, 2019

Conversation

@adamwathan
Copy link
Member

commented Feb 28, 2019

Instead of plugins being configured directly, they grab their configuration from the Tailwind config passed to them. This makes core plugins consistent with how we will recommend third-party plugins be authored so that the configuration for everything in the system is readable through the theme.

This change is purely internal and affects no one. It's less code though so that's cool.

This also effectively undos #644, at least for now, as plugins no longer accept any direct configuration. This is probably better anyways, as now if a plugin did accept optional extra configuration options, they would be completely separate from the theme/variant elements of a plugin, and you could override those options without overriding the values and variants. @MichaelDeBoey will be pleased :)

This was tedious torture, thanks @bradlc 馃が

adamwathan added 26 commits Feb 28, 2019
@adamwathan adamwathan merged commit 49341ce into next Feb 28, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adamwathan adamwathan deleted the source-options-from-config branch Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.