Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on perfectionist, implement simple formatting from scratch #847

Merged
merged 3 commits into from Apr 17, 2019

Conversation

Projects
None yet
2 participants
@adamwathan
Copy link
Member

commented Apr 16, 2019

Resolves #817, simplifies a bunch of stuff too.

Also noticed some inconsistencies in values we were using in the config (some had leading zeroes, others didn't, some had spaces between commas, others didn't, etc.) so cleaned all that up as well, as we were accidentally relying on perfectionist to do that for us.

Also fixed a small bug in the theme function where array values were implicitly being converted to a string by Node instead of us handling that explicitly.

adamwathan added some commits Apr 16, 2019

@adamwathan adamwathan merged commit 4f58205 into next Apr 17, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@adamwathan adamwathan deleted the remove-perfectionist-dependency branch Apr 17, 2019

@hacknug

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

Any plans on turning this into a full-featured alternative to Perfectionist?

@adamwathan

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2019

Nah :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.