From 8652f806eb19f51e2938b727c5b68cfba3b973fb Mon Sep 17 00:00:00 2001 From: Robin Malfait Date: Thu, 11 Apr 2024 11:26:19 +0200 Subject: [PATCH] replace `as unknown as XYZ` with `as XYZ` (#3091) --- .../src/components/button/button.tsx | 2 +- .../src/components/checkbox/checkbox.tsx | 2 +- .../src/components/combobox/combobox.test.tsx | 6 ++--- .../src/components/combobox/combobox.tsx | 24 +++++++------------ .../data-interactive/data-interactive.tsx | 2 +- .../components/description/description.tsx | 2 +- .../src/components/dialog/dialog.tsx | 14 ++++------- .../src/components/disclosure/disclosure.tsx | 12 ++++------ .../src/components/field/field.tsx | 2 +- .../src/components/fieldset/fieldset.tsx | 2 +- .../src/components/focus-trap/focus-trap.tsx | 2 +- .../src/components/input/input.tsx | 2 +- .../src/components/label/label.tsx | 2 +- .../src/components/legend/legend.tsx | 2 +- .../src/components/listbox/listbox.tsx | 16 +++++-------- .../src/components/menu/menu.tsx | 16 ++++++------- .../src/components/popover/popover.test.tsx | 2 +- .../src/components/popover/popover.tsx | 12 ++++------ .../src/components/portal/portal.tsx | 2 +- .../components/radio-group/radio-group.tsx | 10 ++++---- .../src/components/select/select.tsx | 2 +- .../src/components/switch/switch.tsx | 4 ++-- .../src/components/tabs/tabs.tsx | 10 ++++---- .../src/components/textarea/textarea.tsx | 2 +- .../src/components/tooltip/tooltip.tsx | 6 ++--- .../components/transition/transition.test.tsx | 2 +- .../src/components/transition/transition.tsx | 10 +++----- .../src/hooks/use-by-comparator.ts | 2 +- .../@headlessui-react/src/hooks/use-watch.ts | 4 ++-- .../@headlessui-react/src/internal/hidden.tsx | 2 +- .../@headlessui-react/src/internal/modal.tsx | 2 +- .../src/utils/focus-management.ts | 2 +- .../@headlessui-react/src/utils/render.ts | 2 +- 33 files changed, 77 insertions(+), 107 deletions(-) diff --git a/packages/@headlessui-react/src/components/button/button.tsx b/packages/@headlessui-react/src/components/button/button.tsx index daf3e9bfc..ba5cdb983 100644 --- a/packages/@headlessui-react/src/components/button/button.tsx +++ b/packages/@headlessui-react/src/components/button/button.tsx @@ -78,4 +78,4 @@ export interface _internal_ComponentButton extends HasDisplayName { ): JSX.Element } -export let Button = forwardRefWithAs(ButtonFn) as unknown as _internal_ComponentButton +export let Button = forwardRefWithAs(ButtonFn) as _internal_ComponentButton diff --git a/packages/@headlessui-react/src/components/checkbox/checkbox.tsx b/packages/@headlessui-react/src/components/checkbox/checkbox.tsx index 8ee45ba86..1c179ecc8 100644 --- a/packages/@headlessui-react/src/components/checkbox/checkbox.tsx +++ b/packages/@headlessui-react/src/components/checkbox/checkbox.tsx @@ -198,4 +198,4 @@ export interface _internal_ComponentCheckbox extends HasDisplayName { ): JSX.Element } -export let Checkbox = forwardRefWithAs(CheckboxFn) as unknown as _internal_ComponentCheckbox +export let Checkbox = forwardRefWithAs(CheckboxFn) as _internal_ComponentCheckbox diff --git a/packages/@headlessui-react/src/components/combobox/combobox.test.tsx b/packages/@headlessui-react/src/components/combobox/combobox.test.tsx index 15a64472a..76d4dfc0d 100644 --- a/packages/@headlessui-react/src/components/combobox/combobox.test.tsx +++ b/packages/@headlessui-react/src/components/combobox/combobox.test.tsx @@ -2015,7 +2015,7 @@ describe.each([{ virtual: true }, { virtual: false }])( options, disabled: isDisabled, }} - value={'test' as unknown as T} + value={'test' as T} onChange={NOOP} {...comboboxProps} > @@ -4456,7 +4456,7 @@ describe.each([{ virtual: true }, { virtual: false }])('Mouse interactions %s', return typeof option === 'string' ? false : typeof option === 'object' && option !== null && 'disabled' in option - ? (option?.disabled as unknown as boolean | undefined) ?? false + ? (option?.disabled as boolean | undefined) ?? false : false } if (virtual) { @@ -4466,7 +4466,7 @@ describe.each([{ virtual: true }, { virtual: false }])('Mouse interactions %s', options, disabled: isDisabled, }} - value={'test' as unknown as T} + value={'test' as T} onChange={NOOP} {...comboboxProps} > diff --git a/packages/@headlessui-react/src/components/combobox/combobox.tsx b/packages/@headlessui-react/src/components/combobox/combobox.tsx index 055608312..900ec342e 100644 --- a/packages/@headlessui-react/src/components/combobox/combobox.tsx +++ b/packages/@headlessui-react/src/components/combobox/combobox.tsx @@ -814,7 +814,7 @@ function ComboboxFn { if (typeof displayValue === 'function' && data.value !== undefined) { - return displayValue(data.value as unknown as TType) ?? '' + return displayValue(data.value as TType) ?? '' } else if (typeof data.value === 'string') { return data.value } else { @@ -1319,9 +1319,7 @@ function InputFn< 'aria-autocomplete': 'list', defaultValue: props.defaultValue ?? - (data.defaultValue !== undefined - ? displayValue?.(data.defaultValue as unknown as TType) - : null) ?? + (data.defaultValue !== undefined ? displayValue?.(data.defaultValue as TType) : null) ?? data.defaultValue, disabled: disabled || undefined, autoFocus, @@ -1869,19 +1867,13 @@ export interface _internal_ComponentComboboxOption extends HasDisplayName { ): JSX.Element } -let ComboboxRoot = forwardRefWithAs(ComboboxFn) as unknown as _internal_ComponentCombobox -export let ComboboxButton = forwardRefWithAs( - ButtonFn -) as unknown as _internal_ComponentComboboxButton -export let ComboboxInput = forwardRefWithAs(InputFn) as unknown as _internal_ComponentComboboxInput +let ComboboxRoot = forwardRefWithAs(ComboboxFn) as _internal_ComponentCombobox +export let ComboboxButton = forwardRefWithAs(ButtonFn) as _internal_ComponentComboboxButton +export let ComboboxInput = forwardRefWithAs(InputFn) as _internal_ComponentComboboxInput /** @deprecated use `