Improve typeahead search logic #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that if you have 4 items: - Alice - Bob - Charlie - Bob And you search for `b`, then you jump to the first `Bob`, but if yuo search again for `b` then we used to go to the very first `Bob` because we always searched from the top. Now we will search from the active item and onwards. Which means that we will now jump to the second `Bob`.
|
This pull request is being automatically deployed with Vercel (learn more). headlessui-react – ./packages/@headlessui-react🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-react/6GNofQuCiS1aSiWvUZrVUTngY9HW headlessui-vue – ./packages/@headlessui-vue🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-vue/ADjjPEVdkpjnqEzupXwaFnHv4yeX |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make some improvements to the typeahead logic.
This ensures that if you have 4 items:
And you search for
b, then you jump to the firstBob, but if yuosearch again for
bthen we used to go to the very firstBobbecausewe always searched from the top. Now we will search from the active item
and onwards. Which means that we will now jump to the second
Bob.Closes: #1046