Ensure hidden TabPanel components are hidden from the accessibility tree
#2708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
changed the title
TabPanel components are hidden in the accessibility treeTabPanel components are hidden from the accessibility tree
RobinMalfait
force-pushed
the
fix/issue-2688
branch
from
83aa049
to
7d3c1ec
Compare
The `Hidden` component only adds the `aria-hidden` by default if the `Focusable` feature is passed. In our case we don't want it to be focusable so therefore we didn't pass this feature flag. Because we didn't pass the `Focusable` feature, the `display: hidden` was used which makes it completely unfocusable to the keyboard of the user which is what we want. However, the VoiceOver cursor _can_ get into those elements. Adding the `aria-hidden` manually to these tabs solves the issue.
RobinMalfait
force-pushed
the
fix/issue-2688
branch
from
4413dd7
to
1edb114
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the hidden
TabPanelcomponents are focusable in the accessibility tree and the VoiceOver cursor can access them.Adding the
aria-hidden="true"fixes this issue.Fixes: #2688