From 1dfd11394bccc94f37d36d6e85e14fcbec2009d6 Mon Sep 17 00:00:00 2001 From: Eran Hirsch Date: Fri, 28 Apr 2023 19:51:52 +0300 Subject: [PATCH] Reset dialog element styles (#11069) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * disable useragent styling for dialog * nits * Update src/css/preflight.css * Simplify dialog reset We don’t want to reset everything here. Just the padding should be enough. * Update test --------- Co-authored-by: Robin Malfait Co-authored-by: Jordan Pittman --- src/css/preflight.css | 7 + tests/source-maps.test.js | 261 +++++++++++++++++++------------------- 2 files changed, 140 insertions(+), 128 deletions(-) diff --git a/src/css/preflight.css b/src/css/preflight.css index a53bd8c742f1..e5e52cd8f323 100644 --- a/src/css/preflight.css +++ b/src/css/preflight.css @@ -302,6 +302,13 @@ menu { padding: 0; } +/* +Reset default styling for dialogs. +*/ +dialog { + padding: 0; +} + /* Prevent resizing textareas horizontally by default. */ diff --git a/tests/source-maps.test.js b/tests/source-maps.test.js index 96f0d04a6144..a19aea687bdd 100644 --- a/tests/source-maps.test.js +++ b/tests/source-maps.test.js @@ -261,139 +261,144 @@ crosscheck(({ stable, oxide }) => { '2:20 -> 305:0', '2:6 -> 307:0', '2:20 -> 309:1', - '2:6 -> 311:0', - '2:6-20 -> 312:2-18', - '2:20 -> 313:0', - '2:6 -> 315:0', - '2:20 -> 318:1', - '2:6 -> 320:0', - '2:6-20 -> 322:2-20', - '2:6-20 -> 323:2-24', - '2:20 -> 324:0', - '2:6 -> 326:0', - '2:20 -> 328:1', - '2:6 -> 330:0', - '2:6-20 -> 332:2-17', - '2:20 -> 333:0', - '2:6 -> 335:0', - '2:20 -> 337:1', - '2:6 -> 338:0', + '2:6 -> 310:0', + '2:6-20 -> 311:2-12', + '2:20 -> 312:0', + '2:6 -> 314:0', + '2:20 -> 316:1', + '2:6 -> 318:0', + '2:6-20 -> 319:2-18', + '2:20 -> 320:0', + '2:6 -> 322:0', + '2:20 -> 325:1', + '2:6 -> 327:0', + '2:6-20 -> 329:2-20', + '2:6-20 -> 330:2-24', + '2:20 -> 331:0', + '2:6 -> 333:0', + '2:20 -> 335:1', + '2:6 -> 337:0', '2:6-20 -> 339:2-17', '2:20 -> 340:0', '2:6 -> 342:0', - '2:20 -> 346:1', - '2:6 -> 348:0', - '2:6-20 -> 356:2-24', - '2:6-20 -> 357:2-32', - '2:20 -> 358:0', - '2:6 -> 360:0', - '2:20 -> 362:1', - '2:6 -> 364:0', - '2:6-20 -> 366:2-17', - '2:6-20 -> 367:2-14', - '2:20 -> 368:0', - '2:6-20 -> 370:0-72', + '2:20 -> 344:1', + '2:6 -> 345:0', + '2:6-20 -> 346:2-17', + '2:20 -> 347:0', + '2:6 -> 349:0', + '2:20 -> 353:1', + '2:6 -> 355:0', + '2:6-20 -> 363:2-24', + '2:6-20 -> 364:2-32', + '2:20 -> 365:0', + '2:6 -> 367:0', + '2:20 -> 369:1', '2:6 -> 371:0', - '2:6-20 -> 372:2-15', - '2:20 -> 373:0', - '2:6 -> 375:0', - '2:6-20 -> 376:2-26', - '2:6-20 -> 377:2-26', - '2:6-20 -> 378:2-21', - '2:6-20 -> 379:2-21', - '2:6-20 -> 380:2-16', - '2:6-20 -> 381:2-16', - '2:6-20 -> 382:2-16', - '2:6-20 -> 383:2-17', - '2:6-20 -> 384:2-17', - '2:6-20 -> 385:2-15', - '2:6-20 -> 386:2-15', - '2:6-20 -> 387:2-20', - '2:6-20 -> 388:2-40', - '2:6-20 -> 389:2-32', - '2:6-20 -> 390:2-31', - '2:6-20 -> 391:2-30', - '2:6-20 -> 392:2-17', - '2:6-20 -> 393:2-22', - '2:6-20 -> 394:2-24', - '2:6-20 -> 395:2-25', - '2:6-20 -> 396:2-26', - '2:6-20 -> 397:2-20', - '2:6-20 -> 398:2-29', - '2:6-20 -> 399:2-30', - '2:6-20 -> 400:2-40', - '2:6-20 -> 401:2-36', - '2:6-20 -> 402:2-29', - '2:6-20 -> 403:2-24', - '2:6-20 -> 404:2-32', - '2:6-20 -> 405:2-14', - '2:6-20 -> 406:2-20', - '2:6-20 -> 407:2-18', - '2:6-20 -> 408:2-19', - '2:6-20 -> 409:2-20', - '2:6-20 -> 410:2-16', - '2:6-20 -> 411:2-18', - '2:6-20 -> 412:2-15', - '2:6-20 -> 413:2-21', - '2:6-20 -> 414:2-23', - '2:6-20 -> 415:2-29', - '2:6-20 -> 416:2-27', - '2:6-20 -> 417:2-28', - '2:6-20 -> 418:2-29', - '2:6-20 -> 419:2-25', - '2:6-20 -> 420:2-26', - '2:6-20 -> 421:2-27', - '2:6 -> 422:2', - '2:20 -> 423:0', - '2:6 -> 425:0', - '2:6-20 -> 426:2-26', + '2:6-20 -> 373:2-17', + '2:6-20 -> 374:2-14', + '2:20 -> 375:0', + '2:6-20 -> 377:0-72', + '2:6 -> 378:0', + '2:6-20 -> 379:2-15', + '2:20 -> 380:0', + '2:6 -> 382:0', + '2:6-20 -> 383:2-26', + '2:6-20 -> 384:2-26', + '2:6-20 -> 385:2-21', + '2:6-20 -> 386:2-21', + '2:6-20 -> 387:2-16', + '2:6-20 -> 388:2-16', + '2:6-20 -> 389:2-16', + '2:6-20 -> 390:2-17', + '2:6-20 -> 391:2-17', + '2:6-20 -> 392:2-15', + '2:6-20 -> 393:2-15', + '2:6-20 -> 394:2-20', + '2:6-20 -> 395:2-40', + '2:6-20 -> 396:2-32', + '2:6-20 -> 397:2-31', + '2:6-20 -> 398:2-30', + '2:6-20 -> 399:2-17', + '2:6-20 -> 400:2-22', + '2:6-20 -> 401:2-24', + '2:6-20 -> 402:2-25', + '2:6-20 -> 403:2-26', + '2:6-20 -> 404:2-20', + '2:6-20 -> 405:2-29', + '2:6-20 -> 406:2-30', + '2:6-20 -> 407:2-40', + '2:6-20 -> 408:2-36', + '2:6-20 -> 409:2-29', + '2:6-20 -> 410:2-24', + '2:6-20 -> 411:2-32', + '2:6-20 -> 412:2-14', + '2:6-20 -> 413:2-20', + '2:6-20 -> 414:2-18', + '2:6-20 -> 415:2-19', + '2:6-20 -> 416:2-20', + '2:6-20 -> 417:2-16', + '2:6-20 -> 418:2-18', + '2:6-20 -> 419:2-15', + '2:6-20 -> 420:2-21', + '2:6-20 -> 421:2-23', + '2:6-20 -> 422:2-29', + '2:6-20 -> 423:2-27', + '2:6-20 -> 424:2-28', + '2:6-20 -> 425:2-29', + '2:6-20 -> 426:2-25', '2:6-20 -> 427:2-26', - '2:6-20 -> 428:2-21', - '2:6-20 -> 429:2-21', - '2:6-20 -> 430:2-16', - '2:6-20 -> 431:2-16', - '2:6-20 -> 432:2-16', - '2:6-20 -> 433:2-17', - '2:6-20 -> 434:2-17', - '2:6-20 -> 435:2-15', - '2:6-20 -> 436:2-15', - '2:6-20 -> 437:2-20', - '2:6-20 -> 438:2-40', - '2:6-20 -> 439:2-32', - '2:6-20 -> 440:2-31', - '2:6-20 -> 441:2-30', - '2:6-20 -> 442:2-17', - '2:6-20 -> 443:2-22', - '2:6-20 -> 444:2-24', - '2:6-20 -> 445:2-25', - '2:6-20 -> 446:2-26', - '2:6-20 -> 447:2-20', - '2:6-20 -> 448:2-29', - '2:6-20 -> 449:2-30', - '2:6-20 -> 450:2-40', - '2:6-20 -> 451:2-36', - '2:6-20 -> 452:2-29', - '2:6-20 -> 453:2-24', - '2:6-20 -> 454:2-32', - '2:6-20 -> 455:2-14', - '2:6-20 -> 456:2-20', - '2:6-20 -> 457:2-18', - '2:6-20 -> 458:2-19', - '2:6-20 -> 459:2-20', - '2:6-20 -> 460:2-16', - '2:6-20 -> 461:2-18', - '2:6-20 -> 462:2-15', - '2:6-20 -> 463:2-21', - '2:6-20 -> 464:2-23', - '2:6-20 -> 465:2-29', - '2:6-20 -> 466:2-27', - '2:6-20 -> 467:2-28', - '2:6-20 -> 468:2-29', - '2:6-20 -> 469:2-25', - '2:6-20 -> 470:2-26', - '2:6-20 -> 471:2-27', - '2:6 -> 472:2', - '2:20 -> 473:0', + '2:6-20 -> 428:2-27', + '2:6 -> 429:2', + '2:20 -> 430:0', + '2:6 -> 432:0', + '2:6-20 -> 433:2-26', + '2:6-20 -> 434:2-26', + '2:6-20 -> 435:2-21', + '2:6-20 -> 436:2-21', + '2:6-20 -> 437:2-16', + '2:6-20 -> 438:2-16', + '2:6-20 -> 439:2-16', + '2:6-20 -> 440:2-17', + '2:6-20 -> 441:2-17', + '2:6-20 -> 442:2-15', + '2:6-20 -> 443:2-15', + '2:6-20 -> 444:2-20', + '2:6-20 -> 445:2-40', + '2:6-20 -> 446:2-32', + '2:6-20 -> 447:2-31', + '2:6-20 -> 448:2-30', + '2:6-20 -> 449:2-17', + '2:6-20 -> 450:2-22', + '2:6-20 -> 451:2-24', + '2:6-20 -> 452:2-25', + '2:6-20 -> 453:2-26', + '2:6-20 -> 454:2-20', + '2:6-20 -> 455:2-29', + '2:6-20 -> 456:2-30', + '2:6-20 -> 457:2-40', + '2:6-20 -> 458:2-36', + '2:6-20 -> 459:2-29', + '2:6-20 -> 460:2-24', + '2:6-20 -> 461:2-32', + '2:6-20 -> 462:2-14', + '2:6-20 -> 463:2-20', + '2:6-20 -> 464:2-18', + '2:6-20 -> 465:2-19', + '2:6-20 -> 466:2-20', + '2:6-20 -> 467:2-16', + '2:6-20 -> 468:2-18', + '2:6-20 -> 469:2-15', + '2:6-20 -> 470:2-21', + '2:6-20 -> 471:2-23', + '2:6-20 -> 472:2-29', + '2:6-20 -> 473:2-27', + '2:6-20 -> 474:2-28', + '2:6-20 -> 475:2-29', + '2:6-20 -> 476:2-25', + '2:6-20 -> 477:2-26', + '2:6-20 -> 478:2-27', + '2:6 -> 479:2', + '2:20 -> 480:0', ]) })