Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test for #2823 #2824

merged 4 commits into from Nov 26, 2020


Copy link

@stefanfisk stefanfisk commented Nov 19, 2020

Here's a failing test for #2823.

Fixes: #2823

Copy link

Codecov Report

Merging #2824 (1e9ddc6) into master (3ea5e18) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2824      +/-   ##
+ Coverage   93.20%   93.22%   +0.01%     
  Files         177      177              
  Lines        1795     1800       +5     
  Branches      317      318       +1     
+ Hits         1673     1678       +5     
  Misses        105      105              
  Partials       17       17              
Impacted Files Coverage Δ
src/lib/substituteClassApplyAtRules.js 94.66% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ea5e18...1e9ddc6. Read the comment docs.

Copy link

Hey! Thank you for your PR! I love that you pushed a failing test!
Much appreciated! 🙏

I pushed the fixes directly to your branch.


@RobinMalfait RobinMalfait merged commit 1e0fc09 into tailwindlabs:master Nov 26, 2020
@stefanfisk stefanfisk deleted the issue/2823 branch November 26, 2020 13:54
Copy link
Contributor Author

The pleasure's mine - thanks for a great library!

This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

@apply does not remove !important when used on multiple selectors.
3 participants