Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for display : inline-table #3563

Merged
merged 2 commits into from Apr 3, 2021

Conversation

erikverbeek
Copy link
Contributor

@erikverbeek erikverbeek commented Feb 10, 2021

I was missing a class for the display : inline-table property. I've added it underneath the other display classes and updated the tests to get back to green.

If you accept this request, hopefully it can also be added to V1 as the project I was missing it in still has to support IE11.

@adamwathan
Copy link
Member

adamwathan commented Mar 30, 2021

Hey thanks happy to merge but can you insert it between .table and .table-caption instead? We have .hidden at the very end on purpose because people tend to toggle that with JS and we'd get lots of issues being opened when people expected it to override other display classes.

image

@erikverbeek
Copy link
Contributor Author

erikverbeek commented Mar 30, 2021

I just updated my request with your suggestion. Thanks for the merge and the great framework.

@adamwathan adamwathan merged commit 48d7648 into tailwindlabs:master Apr 3, 2021
2 checks passed
@adamwathan
Copy link
Member

adamwathan commented Apr 3, 2021

Thanks!

adamwathan pushed a commit that referenced this pull request May 7, 2021
* Added support for display : inline-table

* Moved the inline-table class to the suggested spot and updated the tests

Co-authored-by: Erik Verbeek <erik@evidencio.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants