Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify animation tests and improve stability #4250

Merged
merged 1 commit into from May 6, 2021

Conversation

@RobinMalfait
Copy link
Contributor

@RobinMalfait RobinMalfait commented May 5, 2021

This will make sure that we tackle a few additional edge cases:

  • When the name is the same as a reserved keyword, then it will be
    used as a name as well. E.g.: 1s ease ease infinite; Will result in
    a name of ease as well.
  • We take care of trimming and multiple spaces.
  • We don't generate 8k tests anymore, which means that these specific tests only take a second instead of 10 seconds.
This will make sure that we tackle a few additional edge cases:

- When the `name` is the same as a reserved keyword, then it will be
  used as a `name` as well. E.g.: 1s ease ease infinite; Will result in
  a name of `ease` as well.
- We take care of trimming and multiple spaces.
- We don't generate 8k tests anymore, which means that these specific
  tests only take a second instead of 10 seconds.
@RobinMalfait RobinMalfait force-pushed the improve-animation-parsing branch from 6a6f11e to 946e748 May 5, 2021
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented May 5, 2021

Codecov Report

Merging #4250 (946e748) into master (6628eb0) will decrease coverage by 0.07%.
The diff coverage is 97.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4250      +/-   ##
==========================================
- Coverage   71.17%   71.09%   -0.08%     
==========================================
  Files         218      217       -1     
  Lines        4700     4701       +1     
  Branches      760      769       +9     
==========================================
- Hits         3345     3342       -3     
- Misses       1270     1273       +3     
- Partials       85       86       +1     
Impacted Files Coverage Δ
src/util/parseAnimationValue.js 88.88% <97.05%> (-4.87%) ⬇️
tests/util/produce.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6628eb0...946e748. Read the comment docs.

@adamwathan adamwathan merged commit 73877ae into master May 6, 2021
2 checks passed
@adamwathan adamwathan deleted the improve-animation-parsing branch May 6, 2021
@adamwathan
Copy link
Contributor

@adamwathan adamwathan commented May 6, 2021

Thanks sir Robin 😘

@RobinMalfait
Copy link
Contributor Author

@RobinMalfait RobinMalfait commented May 6, 2021

adamwathan added a commit that referenced this issue May 7, 2021
This will make sure that we tackle a few additional edge cases:

- When the `name` is the same as a reserved keyword, then it will be
  used as a `name` as well. E.g.: 1s ease ease infinite; Will result in
  a name of `ease` as well.
- We take care of trimming and multiple spaces.
- We don't generate 8k tests anymore, which means that these specific
  tests only take a second instead of 10 seconds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants