Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement purge safelist #4580

Merged
merged 5 commits into from Jun 9, 2021
Merged

implement purge safelist #4580

merged 5 commits into from Jun 9, 2021

Conversation

@RobinMalfait
Copy link
Contributor

@RobinMalfait RobinMalfait commented Jun 8, 2021

  • fix --help output in tests
  • add tests to ensure we can use purge.safelist
  • implement the purge.safelist for strings
@RobinMalfait RobinMalfait force-pushed the implement-purge-safelist branch from 425a939 to 658424a Jun 8, 2021
`purge.options.safelist` doesn't exists yet.
@adamwathan adamwathan merged commit 8518fee into master Jun 9, 2021
3 checks passed
3 checks passed
@github-actions
build (12)
Details
@github-actions
build (14)
Details
@github-actions
build (16)
Details
@adamwathan adamwathan deleted the implement-purge-safelist branch Jun 9, 2021
@chris-morgan
Copy link

@chris-morgan chris-morgan commented Jun 18, 2021

I just happened to read the 2.2.0 release notes, and just want to say: safelist is a rather bad name here, honestly worse to my Australian eyes than whitelist, which would still be a poor name for the same reason: it doesn’t convey the meaning well. I recommend deprecating this newly-released name in favour of something semantically superior.

Some relevant words: “retain”, “keep”, “preserve”; as an outsider, I think my favourites from this couple of minutes of thought are keepClasses and retain.

(Feel free to do something or ignore me as you desire; I don’t intend to engage any further; I don’t even use Tailwind at this time.)

@xiCO2k
Copy link

@xiCO2k xiCO2k commented Sep 8, 2021

@RobinMalfait Hey Robin, checking out the safelist stuff, there is any particular reason to not support an array with regex's?

image

Checked the documentation on the PurgeCSS docs (https://purgecss.com/safelisting.html#patterns) and does looks like is supported.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants