Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tmp file as a touch file #4650

Merged
merged 4 commits into from Jun 15, 2021
Merged

Use tmp file as a touch file #4650

merged 4 commits into from Jun 15, 2021

Conversation

@RobinMalfait
Copy link
Contributor

@RobinMalfait RobinMalfait commented Jun 15, 2021

We were using a .tailwindcss directory to store all touch files. This was necessary for webpack 5, but now webpack 5 can use tracking context instead.

Fixes: #4569 (by not writing to a .tailwindcss folder anymore)

When more tools catch up with the latest postcss dependency tracking,
then we probably don't even need this anymore. However, it is a good
practice to put (global) caches in ~/.cache and (global) configs in
~/.config

Fixes: #4569
Because of some changes in tailwind itself, the base selector contains a
ton of new --tw-* custom properties. Keeping this up to date might be a
bit of an annoying challenge. So instead we now check for the selector
to be present.
@RobinMalfait RobinMalfait changed the title use ~/.cache/tailwindcss as default touch dir Use tmp file as a touch file Jun 15, 2021
@adamwathan adamwathan merged commit 38a71d8 into master Jun 15, 2021
3 checks passed
3 checks passed
@github-actions
build (12)
Details
@github-actions
build (14)
Details
@github-actions
build (16)
Details
@adamwathan adamwathan deleted the use-cache-folder branch Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants