Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when dash is used as custom separator #4704

Merged
merged 1 commit into from Jun 18, 2021

Conversation

adamwathan
Copy link
Member

@adamwathan adamwathan commented Jun 18, 2021

Right now using a dash as a custom separator causes a bunch of errors because it's extremely difficult if not impossible to handle properly.

This PR throws an explicit error so the user has some idea what's actually going wrong, instead of having to Google around for other cryptic errors to figure out what the real source of the problem is.

If we can support this one day then we can get rid of this exception, but until we can actually support it it seems much better to error explicitly.

@adamwathan adamwathan merged commit 1d72dc2 into master Jun 18, 2021
3 checks passed
@adamwathan adamwathan deleted the error-on-dash-separator branch Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant