Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated focus style fix #4780

Merged
merged 2 commits into from Jun 23, 2021
Merged

Conversation

adamwathan
Copy link
Member

@adamwathan adamwathan commented Jun 23, 2021

Resolves #4769.

This PR removes some styles we originally inherited from SUIT CSS Base that corrected a focus style bug in IE and Firefox where buttons with transparent backgrounds lost their focus styles. We no longer support IE at all, and this bug has since been corrected in Firefox, so removing this fix. Removing actually improves accessibility in Firefox since they have switched to a much more pronounced default focus style, whereas these old styles used a subtle dotted focus ring that is hard to see in many designs.

This has the added benefit of not automatically adding focus styles to buttons on click in Chromium-based browsers.

@adamwathan adamwathan merged commit 063eca6 into master Jun 23, 2021
3 checks passed
@adamwathan adamwathan deleted the remove-outdated-focus-style-fix branch Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant