Make replaced elements block by default, preserve aspect ratio #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by what's being done in the CSS Remedy project, this PR makes replaced elements
display: blockby default, and ensures images and videos don't overflow their parent containers while preserving their intrinsic aspect ratio.In the rare case that you want these elements to be
display: inlineor another display value, you can of course specify that with a utility.There is a chance this may cause weirdness with embedded widgets that expect certain default browser styles, but I tested it with some complex embedded Google Maps examples and saw no negative consequences, so I'm inclined to believe it's probably safe.