Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix matchVariants that use at-rules and placeholders #8392

merged 4 commits into from May 20, 2022


Copy link

Prior to this PR, using the new matchVariant API with super complex format strings like @media (pointer: whatever) { &:blah } didn't work, because we had duplicated some logic but missed some edge cases.

This PR unifies the logic for parsing variant format strings so that anything that works with addVariant is guaranteed to work with matchVariant or arbitrary variants, or anything else.

@adamwathan adamwathan merged commit bb4f5da into master May 20, 2022
@adamwathan adamwathan deleted the fix-complex-matchvariants branch May 20, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants