Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ellipsis truncation not working on some Description Lists on Firefox #71

Closed
inopinatus opened this issue Mar 9, 2020 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@inopinatus
Copy link

inopinatus commented Mar 9, 2020

What component (if applicable)

Not affected: Left-aligned striped in card

Describe the bug

In very narrow viewports, the filenames in the attachment lists are not truncated with ellipsis on Firefox.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Description Lists
  2. Drag each width slider to be very narrow
  3. See error

Expected behavior

truncation with ellipsis in all attachment lists

Screenshots

Side-by-side between bad and good:

Screen Shot 2020-03-09 at 18 59 28

Browser/Device (if applicable)

  • macOS Catalina 10.15.3
  • Firefox 73.0.1 and Firefox Dev Edition 74.0b9

Additional context

Looks like dissimilar classes on the span.

@inopinatus inopinatus added the bug Something isn't working label Mar 9, 2020
@adamwathan
Copy link
Member

Just pushed a fix, thanks for catching! The trick is to add flex-1 w-0 to the span elements that have the file names in them 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants