Skip to content

Conversation

@DerDackel
Copy link
Contributor

@DerDackel DerDackel commented Mar 10, 2023

  • Please check if the PR fulfills these requirements
  • The commit message describes your change
  • Tests for the changes have been added if possible (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Changes are mentioned in the changelog (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Upgrades the AWS SDK libraries as used to AWS SDK v3.

  • What is the current behavior? (You can also link to an open issue here)

Lambda Toolbox uses the old aws-sdk v2 libraries to interact with DynamoDB and make HTTP requests against AWS AppSync GraphQL endpoints

  • What is the new behavior (if this is a feature change)?

Lambda Toolbox uses AWS SDK v3 to achieve the same thing

  • Does this PR introduce a breaking change? (What changes might users need to make in their setup due to this PR?)

Any functionality relying on behaviour or types specific to aws-sdk v2 might break and should be reevaluated. Standard use of the toolbox libraries should not be affected

  • Other information:

Testing is currently rudimentary, I have not yet tested the reworked HTTP request signing for AppSync against a live endpoint at all.

@hoegertn
Copy link
Member

That looks really great.

@hoegertn hoegertn self-requested a review March 10, 2023 16:10
@hoegertn hoegertn added the enhancement New feature or request label Mar 10, 2023
@DerDackel
Copy link
Contributor Author

I added some tests for the updateExistingItem/createUpdate calls, far from exhaustive, but I feel like not much is happening here anymore anyway, so I didn't want to spend too much time on there. I'd still need to test the AppSync GraphQL client, but I have no good idea on how to do that without building up an outright integration test harness. With your thumbs up, I'd mark this as ready.

@DerDackel DerDackel marked this pull request as ready for review March 13, 2023 06:26
@hoegertn hoegertn merged commit 55d2053 into taimos:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants