Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Block: Items carousel (static) #191

Closed
mateuswetah opened this issue Feb 1, 2019 · 3 comments

Comments

@mateuswetah
Copy link
Contributor

commented Feb 1, 2019

A item's carousel, displaying in one line with slider options. Items should be pick from react's modal.
Options:

  • Source (from collection or term's list..?)
  • Automatically slide items;
  • Show or not item's titles;
  • Arrows aside (simular to Funarte)

For rendering this on front-end of the post, we could consider using the same plugin that the theme currently uses for the attachments on item's single page.

Design preview (they say they will probably work more on this):
image

@leogermani leogermani added the gutenberg label Feb 4, 2019

@leogermani leogermani added this to Backlog in tainacan/tainacan Mar 25, 2019

@mateuswetah mateuswetah moved this from Backlog to To Do in tainacan/tainacan Jul 15, 2019

@mateuswetah mateuswetah moved this from To Do to In Progress in tainacan/tainacan Jul 15, 2019

@mateuswetah mateuswetah self-assigned this Jul 17, 2019

@mateuswetah mateuswetah moved this from In Progress to Validation in tainacan/tainacan Jul 24, 2019

@leogermani leogermani added the 0.11 label Jul 31, 2019

@leogermani

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

If you have more than one carroussel in the same page, clicking in the arrow in one carroussel almo moves all the others

@mateuswetah

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

If you have more than one carroussel in the same page, clicking in the arrow in one carroussel almo moves all the others

This should be easy to fix but apparently there is an issue when dealing with separate Vue instances... I opened the issue on the component repository, let's see how it goes...
surmon-china/vue-awesome-swiper#537

@mateuswetah mateuswetah moved this from Validation to In Progress in tainacan/tainacan Jul 31, 2019

@mateuswetah

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

For this first version, we decided to release the block without allowing to have more than one per page/post. This is a option already existing for Gutenberg's "supports" array, so it will be easy to change in the future once we solve this.

@leogermani leogermani moved this from In Progress to Validation in tainacan/tainacan Aug 6, 2019

@leogermani leogermani removed the 0.11 label Aug 12, 2019

@leogermani leogermani added 0.11 and removed Known issues labels Aug 12, 2019

@leogermani leogermani closed this Aug 12, 2019

tainacan/tainacan automation moved this from Validation to Done Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.