Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More powerfull item's selection on static items gutenberg block #234

Closed
mateuswetah opened this issue May 9, 2019 · 0 comments

Comments

@mateuswetah
Copy link
Contributor

commented May 9, 2019

Context and motivation

Current modal for selecting items on static items block works fine but the strategy adopted on the recently released dynamic item block is more powerful, allows filtering and better visualization.

Ideal solution

A modal where the step of selecting items works on an iframe, just like the dynamic items block.

Alternative solutions
Yes, there is actually an "iframeMode" that is being used with "readMode" on the administrative plugin. For this case, we should not use the readMode, so it would render the checkboxes. We need to do a little work before for adding the selected items array to the url.

@mateuswetah mateuswetah added this to Backlog in tainacan/tainacan Jul 18, 2019

@mateuswetah mateuswetah moved this from Backlog to To Do in tainacan/tainacan Aug 13, 2019

@mateuswetah mateuswetah moved this from To Do to In Progress in tainacan/tainacan Aug 13, 2019

@mateuswetah mateuswetah self-assigned this Aug 13, 2019

mateuswetah added a commit that referenced this issue Aug 13, 2019

@mateuswetah mateuswetah moved this from In Progress to Validation in tainacan/tainacan Aug 13, 2019

@leogermani leogermani closed this Aug 22, 2019

tainacan/tainacan automation moved this from Validation to Done Aug 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.