Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Numeric Filter (single value instead of range) #242

Closed
mateuswetah opened this issue May 21, 2019 · 2 comments

Comments

@mateuswetah
Copy link
Contributor

commented May 21, 2019

Range filter is confusing when dealing with only one value, we should have one filter for that.

@mateuswetah mateuswetah created this issue from a note in tainacan/tainacan (Backlog) May 21, 2019

@mateuswetah mateuswetah self-assigned this May 21, 2019

@mateuswetah mateuswetah added the 0.11 label May 21, 2019

@mateuswetah mateuswetah changed the title Create New Numeric Filter (single value instead of range) New Numeric Filter (single value instead of range) May 21, 2019

@mateuswetah mateuswetah moved this from Backlog to To Do in tainacan/tainacan May 21, 2019

@mateuswetah mateuswetah moved this from To Do to In Progress in tainacan/tainacan May 21, 2019

mateuswetah added a commit that referenced this issue May 21, 2019

leogermani added a commit that referenced this issue May 21, 2019

mateuswetah added a commit that referenced this issue May 23, 2019

Sets to false max count option on filters that don't need it. Removes…
… unecessary imports from theme items list. Begins implementation of form component for numeric filter Ref. #242.

@mateuswetah mateuswetah moved this from In Progress to Validation in tainacan/tainacan Jun 3, 2019

@leogermani

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

Not sure if there is a solution but in my laptop the filters break in 2 lines. image below:

Captura de tela de 2019-06-24 05-47-27

@mateuswetah

This comment has been minimized.

Copy link
Contributor Author

commented Jun 24, 2019

Yeah it's ugly... I could find a solution where instead of only occupying this minimum width, the select expands to the maximum. We just can't avoid the break itself, it is necessary because the date field contains a dropdown with the date picker that requires a minimum width. Unfortunately, 1366 width is one of those cases where there is this feeling that we could have more space but the breakpoint already passed due to the filter's list maximum width... hopefully this happens less often on the theme because there the filter's list has more space.

@leogermani leogermani closed this Jun 25, 2019

tainacan/tainacan automation moved this from Validation to Done Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.