Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by Status (private vs public) #248

Closed
mateuswetah opened this issue May 21, 2019 · 4 comments

Comments

@mateuswetah
Copy link
Contributor

commented May 21, 2019

Maybe this should be on the tabs, but we need a way to filter items by public or private on the items list.

@mateuswetah mateuswetah created this issue from a note in tainacan/tainacan (Backlog) May 21, 2019

@mateuswetah mateuswetah self-assigned this May 21, 2019

@mateuswetah mateuswetah added the 0.10 label May 21, 2019

@mateuswetah mateuswetah moved this from Backlog to To Do in tainacan/tainacan May 21, 2019

@mateuswetah

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2019

After discussion, we agreed on using existing tabs to deal with this, as long as we keep the "All items" tab to allow easier manipulation of all public and private items. We might discuss design changes tomorrow.

@mateuswetah mateuswetah moved this from To Do to In Progress in tainacan/tainacan May 22, 2019

mateuswetah added a commit that referenced this issue May 22, 2019

mateuswetah added a commit that referenced this issue May 24, 2019

Several updates to status logic, to iterate over a global array of st…
…atus options. Implements new status tabs layout on Collections and Taxonomies list Ref. #248.

@mateuswetah mateuswetah moved this from In Progress to Validation in tainacan/tainacan May 27, 2019

mateuswetah added a commit that referenced this issue May 27, 2019

@leogermani

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

I checked and this is working nicely.

I also checking logging in with a user that do not have permission to see private items and it works as expected.

But, in those cases, I think it would just be better if we hide this tabs, because thay make no sense if the user cant see private items.

There is a user capability called read_private_tnc_col_{collection_id}_items for this

@leogermani leogermani moved this from Validation to To Do in tainacan/tainacan Jun 13, 2019

@mateuswetah mateuswetah moved this from To Do to Validation in tainacan/tainacan Jun 13, 2019

@leogermani

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

Dont you think we could also hide the "Published" tab? since it shows the same results of "all published items"

@mateuswetah

This comment has been minimized.

Copy link
Contributor Author

commented Jun 24, 2019

I was thinking about this... but in the future, isn't it possible that other status will fit into that tab that doesn't passes any status value? Because this implies putting a logic of not showing published items when the limitation is actually not having capability for seeing public ones... likes changing the UI and API duality..

@leogermani leogermani closed this Jun 25, 2019

tainacan/tainacan automation moved this from Validation to Done Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.