Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Documents of attachments list (admin) #252

Open
mateuswetah opened this issue May 21, 2019 · 3 comments
Open

Show Documents of attachments list (admin) #252

mateuswetah opened this issue May 21, 2019 · 3 comments
Assignees
Labels
1.0

Comments

@mateuswetah
Copy link
Contributor

@mateuswetah mateuswetah commented May 21, 2019

Instead of only showing thumbnails, preview attachments on admin using a modal with the embeded content.

@mateuswetah mateuswetah created this issue from a note in tainacan/tainacan (Backlog) May 21, 2019
@mateuswetah mateuswetah self-assigned this May 21, 2019
@mateuswetah mateuswetah added the 1.0 label May 21, 2019
mateuswetah added a commit that referenced this issue May 30, 2019
…ide an iframe for attachments modal Ref. #252.
@mateuswetah mateuswetah moved this from Backlog to In Progress in tainacan/tainacan May 30, 2019
@mateuswetah

This comment has been minimized.

Copy link
Contributor Author

@mateuswetah mateuswetah commented May 30, 2019

This is actually half done already. It shows the file.description.rendered in a modal. This works fine for html5 video, audio and any image. The latest commit is a workaround for PDF files: it renders their content inside an iframe. I'm not sure this is the best way, but solves for now. We should discuss what else we can render here, otherwise it will appear as a link to the file.

@mateuswetah mateuswetah moved this from In Progress to To Do in tainacan/tainacan Jun 4, 2019
@mateuswetah

This comment has been minimized.

Copy link
Contributor Author

@mateuswetah mateuswetah commented Jul 8, 2019

We should also include here the option to render in the item form the description of the media file, that can be edited on WordPress media modal. We should also be able to render this description from item's API on thumbnail requests, so it can be used for better accessibility.

@leogermani

This comment has been minimized.

Copy link
Contributor

@leogermani leogermani commented Sep 10, 2019

Let's:

  1. See if it is possible to add one more element to the native media WP API Endpoint, adding something like tainacan_rendered to the media.description object
  2. Create a function get_attachment_as_html() that the theme can use
  3. See how the lightbox used in the theme can display a HTML content
@leogermani leogermani moved this from To Do to Backlog in tainacan/tainacan Oct 2, 2019
@leogermani leogermani moved this from Backlog to In Progress in tainacan/tainacan Nov 11, 2019
leogermani added a commit to tainacan/tainacan-theme that referenced this issue Nov 11, 2019
leogermani added a commit that referenced this issue Nov 11, 2019
@leogermani leogermani moved this from In Progress to Validation in tainacan/tainacan Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
tainacan/tainacan
  
Validation
2 participants
You can’t perform that action at this time.