Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Logs #261

Closed
leogermani opened this issue May 21, 2019 · 8 comments
Labels
1.0

Comments

@leogermani
Copy link
Contributor

@leogermani leogermani commented May 21, 2019

Logs are being created but we didnt give much attention to them yet.

For 1.0 we have to make sure they are properly created, stored and displayed to the user

@leogermani leogermani created this issue from a note in tainacan/tainacan (Backlog) May 21, 2019
@leogermani leogermani added the 1.0 label May 21, 2019
@leogermani

This comment has been minimized.

Copy link
Contributor Author

@leogermani leogermani commented Jul 23, 2019

  • review permissions check (bind can_read to items and collections permissions)
leogermani added a commit that referenced this issue Jul 23, 2019
@leogermani leogermani moved this from Backlog to To Do in tainacan/tainacan Aug 22, 2019
@leogermani leogermani moved this from To Do to In Progress in tainacan/tainacan Sep 6, 2019
leogermani added a commit that referenced this issue Sep 6, 2019
leogermani added a commit that referenced this issue Sep 9, 2019
leogermani added a commit that referenced this issue Sep 10, 2019
leogermani added a commit that referenced this issue Sep 12, 2019
leogermani added a commit that referenced this issue Sep 12, 2019
leogermani added a commit that referenced this issue Sep 13, 2019
leogermani added a commit that referenced this issue Sep 13, 2019
leogermani added a commit that referenced this issue Sep 13, 2019
leogermani added a commit that referenced this issue Sep 13, 2019
leogermani added a commit that referenced this issue Sep 13, 2019
@leogermani

This comment has been minimized.

Copy link
Contributor Author

@leogermani leogermani commented Sep 13, 2019

  • Add a note to Log titles when Log was created during an import
  • Verify if and why importers are publishing private items when updating items
  • Remove or change the behavior of the Trash icon in the attachments list. It is not deleting the attachment, but only detaching it from the item. This does not create a log
  • Review the behavior of the "Send to trash" button on the item page. Apparently, it is not sending a DELETE request, but rather sending a PATCH changing the status.
  • Handle Logs in the old format in the api response
leogermani added a commit that referenced this issue Sep 16, 2019
leogermani added a commit that referenced this issue Sep 16, 2019
mateuswetah added a commit that referenced this issue Sep 17, 2019
mateuswetah added a commit that referenced this issue Sep 17, 2019
mateuswetah added a commit that referenced this issue Sep 17, 2019
leogermani added a commit that referenced this issue Sep 17, 2019
leogermani added a commit that referenced this issue Sep 17, 2019
leogermani added a commit that referenced this issue Sep 18, 2019
leogermani added a commit that referenced this issue Sep 18, 2019
@mateuswetah

This comment has been minimized.

Copy link
Contributor

@mateuswetah mateuswetah commented Sep 24, 2019

While implementing admin side, some issues were noticed:

  • After updates on translatable labels, I can't identify updates that are corresponding to metadata and filters sorting updates. My suggestion is to treat them as separate actions, which is the way that I've been using to handle different logs display;
  • Also, one of the labels is Ordination metadata, is that correct?
  • If I set a document of type PDF" the old_value and new_value will return me the Document, which is the ID here, but not the Document Type.
  • In one of my tests, after setting a document of type PDF, the response from the logs API included not only a item object , with the related object, but a items with the same content!
@mateuswetah

This comment has been minimized.

Copy link
Contributor

@mateuswetah mateuswetah commented Sep 26, 2019

One extra thing:

  • Keep legacy logs working;
@leogermani

This comment has been minimized.

Copy link
Contributor Author

@leogermani leogermani commented Sep 27, 2019

  • add links to all related objects (item, metadata, collection, etc...)
@leogermani

This comment has been minimized.

Copy link
Contributor Author

@leogermani leogermani commented Sep 27, 2019

  • fix css for search and date filter
mateuswetah added a commit that referenced this issue Sep 30, 2019
@mateuswetah

This comment has been minimized.

Copy link
Contributor

@mateuswetah mateuswetah commented Sep 30, 2019

Apparently,

  • Filter updates on repository level are not setting log title or description

They also return collection_id as filter_in_repository, whereas in repository metadata this goes as default. It would be good to set a standard. This detail seems to be treated all over the admin code actually, many cases of OR handling the situation.

So far, there is no direct way to achieve Taxonomy Id on a Term update, as the object.taxonomy brings only something like tnc_tax_133188. If it is bad to handle this on frontend then we need to

  • Return taxonomy_id on related object when updating a term.
@mateuswetah

This comment has been minimized.

Copy link
Contributor

@mateuswetah mateuswetah commented Oct 2, 2019

Return creation_date values formatted nicely as in Collection's end
point :)

leogermani added a commit that referenced this issue Oct 4, 2019
@leogermani leogermani moved this from In Progress to Validation in tainacan/tainacan Oct 9, 2019
leogermani added a commit that referenced this issue Oct 11, 2019
@leogermani leogermani moved this from Validation to Done in tainacan/tainacan Oct 24, 2019
@leogermani leogermani closed this Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.