Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better warning for sorting effects on item's list. #278

Closed
mateuswetah opened this issue Jul 17, 2019 · 10 comments

Comments

@mateuswetah
Copy link
Contributor

commented Jul 17, 2019

The tooltip aside the number of item's on list is not enough to indicate that custom metadata sorting may be causing the list to have less items. We should indicate this more clearer.

@mateuswetah mateuswetah created this issue from a note in tainacan/tainacan (Backlog) Jul 17, 2019

@mateuswetah mateuswetah moved this from Backlog to To Do in tainacan/tainacan Jul 17, 2019

@leogermani leogermani moved this from To Do to In Progress in tainacan/tainacan Jul 18, 2019

@leogermani

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2019

@leogermani

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2019

It looks good to me.

I think we should remove the option to dismiss this warning, and leave it there always.

It would be nice to have a different behavior when the list brings no items. Maybe a different message and a different placeholder that says "no items were created in this collection".

could be "no items found, only items with XXX are been displayed. perhaps order by something else?"

@mateuswetah

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2019

I agree with the label change for empty list. I don't agree with removing the option to dismiss although. This is not like what happens to the modal, where it actually never appears again. If a user enters the item's list again, it will be there. So it is already annoyingly "on the face".

@leogermani

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2019

Ok, but now you have to leave the list and come back to it to see the warning again.

If you change the order to sort by another metadatum, the warning should re-appear

@mateuswetah

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2019

Agreed!

mateuswetah added a commit that referenced this issue Jul 18, 2019

mateuswetah added a commit that referenced this issue Jul 18, 2019

@mateuswetah mateuswetah moved this from In Progress to Validation in tainacan/tainacan Jul 18, 2019

@leogermani

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

When no items are found, I think we should not have this "no item created in this collection - add new"

Captura de tela de 2019-07-31 14-42-59

@leogermani leogermani added the 0.11 label Jul 31, 2019

@mateuswetah

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

When no items are found, I think we should not have this "no item created in this collection - add new"

@leogermani, this separation is made today by checking ithe value returned by X-WP-Total, then instead of showing this message, this is shown:

image

I use it to differentiate situations where no results exist from situations where the list is actually empty.

@leogermani

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

But did you see my screenshot?

I think the difference is because I dont have any filters applied

@mateuswetah

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

I see... I'm just thinking how would I safely differentiate this two states...

@mateuswetah

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

Check latest commit (00ec44a).

@leogermani leogermani closed this Aug 2, 2019

tainacan/tainacan automation moved this from Validation to Done Aug 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.