Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rely on sessions to initalize importers and exporters #313

Closed
leogermani opened this issue Oct 8, 2019 · 1 comment
Assignees

Comments

@leogermani
Copy link
Contributor

@leogermani leogermani commented Oct 8, 2019

We had some issues with the approach of initializing importers based on PHP SESSION to hold the state between several requests. In some servers, the Session is lost and we have not been able to reproduce this error on our environments.

There is no special reason why we should keep relying on sessions, that was an easy way to implement it but we could/should move to a database based solution.

@leogermani leogermani self-assigned this Oct 8, 2019
@leogermani leogermani added this to To Do in tainacan/tainacan Oct 8, 2019
@leogermani leogermani moved this from To Do to In Progress in tainacan/tainacan Oct 8, 2019
@leogermani

This comment has been minimized.

Copy link
Contributor Author

@leogermani leogermani commented Oct 8, 2019

  • add transient importers and exporters to garbage collector
leogermani added a commit that referenced this issue Oct 9, 2019
@leogermani leogermani moved this from In Progress to Validation in tainacan/tainacan Oct 9, 2019
vnmedeiros added a commit that referenced this issue Oct 11, 2019
vnmedeiros added a commit that referenced this issue Oct 11, 2019
@leogermani leogermani moved this from Validation to Done in tainacan/tainacan Oct 22, 2019
vnmedeiros added a commit that referenced this issue Oct 24, 2019
@leogermani leogermani closed this Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1 participant
You can’t perform that action at this time.