Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New (themed) difficulty/shot mode descriptions #192

Merged
merged 10 commits into from Feb 27, 2020

Conversation

@StarWitch
Copy link
Contributor

StarWitch commented Feb 23, 2020

This is just a bit of fun I think could make the Difficulty Select and shot types more in-line with the overall theme of the game ("knowledge is power"). A lot of mainline Touhou games have fun "subtitles" for their difficulty modes and shot types, like in TH13: Ten Desires, where "Lunatic Mode" has a subtitle of "Prayer For IT Data Security" (because it's "impossible", heh), and some shot types even affect the story (like in WBaWC).

I edited the .png files and regenerated the atlas. Let me know if it looks good to you, or if we want to change the font. I tried to find something "brushstroke-y" that also wasn't as intense as the main big font.

Here's the text representation of the Difficulty Modes:

Easy / Bachelor's Degree -> "For those just beginning their academic careers"
Normal / Master's Degree -> "All those years of study have finally paid off"
Hard / Ph.D -> "You must really love books"
Lunatic / Post-Doctoral -> "You either die a student, or live long enough to become a professor"

@StarWitch StarWitch changed the title New (themed) difficult modes New (themed) difficulty modes Feb 23, 2020
@Akaricchi

This comment has been minimized.

Copy link
Member

Akaricchi commented Feb 23, 2020

First of all I do like the idea, and I think the new subtitles and descriptions fit nicely. The "Easy" one is a bit problematic because of that pesky Y tail making it hard to read, though.

It looks like you did not actually commit the regenerated atlas texture (should be resources/00-taisei.pkgdir/gfx/atlas_common_ui_0.webp), so these appear broken as they are now in-game. Also make sure it's a .webp and not .png; ninja gen-atlas-common_ui should generate the appropriate file.

I would've recommended editing the high-resolution versions of those images if I've had known you were going to touch them, but if that's a hassle to redo now it's fine.

Perhaps you could also commit the subtitle images separately into the rawmedia repo, and/or the native project files from your image manipulation software (e.g. .psd, .kra, .xcf, etc.). That'll help with future editing should it be ever required.

@Akaricchi Akaricchi added the content label Feb 23, 2020
@Akaricchi Akaricchi added this to the v1.4 milestone Feb 23, 2020
@Akaricchi

This comment has been minimized.

Copy link
Member

Akaricchi commented Feb 24, 2020

Could you also run scripts/optimize-all-img.sh atlas/common_ui/difficulty please?

src/plrmodes/reimu_b.c Outdated Show resolved Hide resolved
src/plrmodes/reimu_a.c Outdated Show resolved Hide resolved
@Akaricchi

This comment has been minimized.

Copy link
Member

Akaricchi commented Feb 24, 2020

The rest of the descriptions are a nice and solid improvement in my opinion.

@Akaricchi

This comment has been minimized.

Copy link
Member

Akaricchi commented Feb 24, 2020

But you might want to rename the PR since it's not just about the difficulty levels anymore, or split the shotmodes off into another one.

@StarWitch StarWitch changed the title New (themed) difficulty modes New (themed) difficulty/shot mode descriptions Feb 24, 2020
@StarWitch

This comment has been minimized.

Copy link
Contributor Author

StarWitch commented Feb 24, 2020

Changes are in! I also modified the title of this PR.

src/plrmodes/reimu_b.c Outdated Show resolved Hide resolved
@StarWitch StarWitch requested a review from Akaricchi Feb 27, 2020
@Akaricchi Akaricchi merged commit b7237d3 into taisei-project:coroutines Feb 27, 2020
@StarWitch StarWitch deleted the StarWitch:difficulty_modes branch Feb 27, 2020
Akaricchi added a commit that referenced this pull request Mar 4, 2020
* new difficult mode suggestions (more within the theme of 'knowledge')

* cleaning up new difficulty descriptions, also changing character select titles to match the STORY.txt

* better transparency mask on Easy

* ran optimize-all-img.sh script

* consistency

* (hopefully) got rid of some half-transparent pixels, especially on Normal.webp

* playermode descriptions! (for real this time)

* Reimu shot description changes (as per PR)

* modify ReimuB description
StarWitch added a commit to StarWitch/taisei that referenced this pull request Mar 6, 2020
* new difficult mode suggestions (more within the theme of 'knowledge')

* cleaning up new difficulty descriptions, also changing character select titles to match the STORY.txt

* better transparency mask on Easy

* ran optimize-all-img.sh script

* consistency

* (hopefully) got rid of some half-transparent pixels, especially on Normal.webp

* playermode descriptions! (for real this time)

* Reimu shot description changes (as per PR)

* modify ReimuB description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.