DMAx.js unnecessary check address

[takutok]

I found a bug in DMAx.js validateDMASource().

For example,If you run in this order ,It is not properly assigned to the source address.
writeDMASource16_0()
writeDMASource16_1()

Tentatively I was like this.
GameBoyAdvanceDMA3.prototype.validateDMASource = function (address) {
address = address | 0;
// if ((address | 0) >= 0x2000000) {
this.source = address | 0;
// }
}

I think perhaps destination is also a problem.

[taisel]

Thanks for bringing this up! I'm surprised someone's reading the code for this project even, it's a free time boredom thing.

I still need to verify what the hardware does for invalid commands. I see how a bunch of emulators do it, but I need to verify the shadowing and masking edge cases.

I'll leave open.

[taisel]

Thanks for bringing this up! I'm surprised someone's reading the code for this project even, it's a free time boredom thing.

I still need to verify what the hardware does for invalid commands. I see how a bunch of emulators do it, but I need to verify the shadowing and masking edge cases.

I'll leave open.