add Voice control interface #32

Merged
merged 5 commits into from Jul 8, 2016

Conversation

Projects
None yet
2 participants
@JeffZhang02747
Contributor

JeffZhang02747 commented Jul 8, 2016

These commits add the functionality of allowing player to control the gameplay through voice with webkitSpeechRecognition and regex.

say "press button/key left" , "press right" , "press the key a", "press b" to press the button

say "increase/up/down/decrease the speed/volume" to modify speed and volume.

@taisel taisel merged commit 9a2f211 into taisel:master Jul 8, 2016

@taisel

This comment has been minimized.

Show comment
Hide comment
@taisel

taisel Jul 8, 2016

Owner

I still don't know how most games can be usable with the delay necessary in voice commands, but I suppose something like Pokemon can be playable under those circumstances.

Owner

taisel commented Jul 8, 2016

I still don't know how most games can be usable with the delay necessary in voice commands, but I suppose something like Pokemon can be playable under those circumstances.

@taisel

This comment has been minimized.

Show comment
Hide comment
@taisel

taisel Jul 8, 2016

Owner

Please create a new pull request with the errors fixed. Specifically, put the global variables under IodineGUI and do not use the global namespace if you can help it. Firefox also gets an error from the voice control being undefined in stable, so the usual window object test should be done rather than a direct variable test.

Owner

taisel commented Jul 8, 2016

Please create a new pull request with the errors fixed. Specifically, put the global variables under IodineGUI and do not use the global namespace if you can help it. Firefox also gets an error from the voice control being undefined in stable, so the usual window object test should be done rather than a direct variable test.

@taisel

This comment has been minimized.

Show comment
Hide comment
@taisel

taisel Jul 8, 2016

Owner

Sorry I merged it earlier, I was busy doing other things and wasn't even able to test, but trusted a pull request as-is without vetting. I don't keep my standards high on code-golfing low profile projects for vetting.

Owner

taisel commented Jul 8, 2016

Sorry I merged it earlier, I was busy doing other things and wasn't even able to test, but trusted a pull request as-is without vetting. I don't keep my standards high on code-golfing low profile projects for vetting.

@taisel

This comment has been minimized.

Show comment
Hide comment
@taisel

taisel Jul 8, 2016

Owner

The edits should be easy to pull off. Either one of us can take it and fix up the pull request. I'm interested in that voice api.

Owner

taisel commented Jul 8, 2016

The edits should be easy to pull off. Either one of us can take it and fix up the pull request. I'm interested in that voice api.

@taisel

This comment has been minimized.

Show comment
Hide comment
@taisel

taisel Jul 8, 2016

Owner

The file also needs a license/contributor message at the top.

Owner

taisel commented Jul 8, 2016

The file also needs a license/contributor message at the top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment