Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upVoice Interface with local var #34
Conversation
JeffZhang02747
added some commits
Jul 9, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
taisel
Jul 9, 2016
Owner
The note about firefox originally was that the check for the voice support existing would throw an error if the voice support did not exist.
|
The note about firefox originally was that the check for the voice support existing would throw an error if the voice support did not exist. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
JeffZhang02747
Jul 9, 2016
Contributor
yes.
To avoid error I check the window object whether contains that attribute first.
|
yes. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
taisel
Jul 9, 2016
Owner
I'm going to verify this pull, but so far it looks like you've addressed the issues mentioned.
|
I'm going to verify this pull, but so far it looks like you've addressed the issues mentioned. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Any pull request for the ReadMe? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
sure, just updated readme |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
taisel
Jul 10, 2016
Owner
I think we need to rewrite the readme entirely. Still gonna use that BSD license message of course though. The readme as a whole is ancient and we should form a separate pull for it.
|
I think we need to rewrite the readme entirely. Still gonna use that BSD license message of course though. The readme as a whole is ancient and we should form a separate pull for it. |
taisel
merged commit a8b4fce
into
taisel:master
Jul 10, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
taisel
Jul 10, 2016
Owner
For all those who have old forks of IodineGBA: Yes, it hasn't been GPL for a few months now. It's BSD licensed.
|
For all those who have old forks of IodineGBA: Yes, it hasn't been GPL for a few months now. It's BSD licensed. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
taisel
Jul 10, 2016
Owner
After re-adding a missing object 51541f9 it works... but barely.
Took 10 minutes to get Google Chrome to register a button press once.
|
After re-adding a missing object 51541f9 it works... but barely. Took 10 minutes to get Google Chrome to register a button press once. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
taisel
Jul 10, 2016
Owner
It's in a state that's not affecting the emulator itself, so we can leave it in. Send in new commits to polish the voice feature if you want.
|
It's in a state that's not affecting the emulator itself, so we can leave it in. Send in new commits to polish the voice feature if you want. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
JeffZhang02747
Jul 13, 2016
Contributor
Did you test the voice with the gameplay background music on or with earphone?
One reason why taking 10 minutes to register a button press might be the webkitSpeechRecognition do not do echo cancellation to filter out noise.
https://docs.google.com/document/d/1QRajFwBdV82aTnPCQNKOfL2ZGkyfG9X9ZfCYgK2xstk/edit?pref=2&pli=1
|
Did you test the voice with the gameplay background music on or with earphone? https://docs.google.com/document/d/1QRajFwBdV82aTnPCQNKOfL2ZGkyfG9X9ZfCYgK2xstk/edit?pref=2&pli=1 |
JeffZhang02747 commentedJul 9, 2016
voice interface added with local variable.
Check window attribute to get the voice recognition object.
Firefox voice recognition is supported on version 49.
https://developer.mozilla.org/en-US/docs/Web/API/Web_Speech_API
Use case: use voice to play delay-tolerated game like Pokemon.
Adjust the volume through voice so you do not need to move the mouse while playing the game.