Voice Interface with local var #34

Merged
merged 3 commits into from Jul 10, 2016

Conversation

Projects
None yet
2 participants
@JeffZhang02747
Contributor

JeffZhang02747 commented Jul 9, 2016

voice interface added with local variable.
Check window attribute to get the voice recognition object.

Firefox voice recognition is supported on version 49.
https://developer.mozilla.org/en-US/docs/Web/API/Web_Speech_API

Use case: use voice to play delay-tolerated game like Pokemon.
Adjust the volume through voice so you do not need to move the mouse while playing the game.

@taisel

This comment has been minimized.

Show comment
Hide comment
@taisel

taisel Jul 9, 2016

Owner

The note about firefox originally was that the check for the voice support existing would throw an error if the voice support did not exist.

Owner

taisel commented Jul 9, 2016

The note about firefox originally was that the check for the voice support existing would throw an error if the voice support did not exist.

@JeffZhang02747

This comment has been minimized.

Show comment
Hide comment
@JeffZhang02747

JeffZhang02747 Jul 9, 2016

Contributor

yes.
To avoid error I check the window object whether contains that attribute first.

Contributor

JeffZhang02747 commented Jul 9, 2016

yes.
To avoid error I check the window object whether contains that attribute first.

@taisel

This comment has been minimized.

Show comment
Hide comment
@taisel

taisel Jul 9, 2016

Owner

I'm going to verify this pull, but so far it looks like you've addressed the issues mentioned.

Owner

taisel commented Jul 9, 2016

I'm going to verify this pull, but so far it looks like you've addressed the issues mentioned.

@taisel

This comment has been minimized.

Show comment
Hide comment
@taisel

taisel Jul 9, 2016

Owner

Any pull request for the ReadMe?

Owner

taisel commented Jul 9, 2016

Any pull request for the ReadMe?

@JeffZhang02747

This comment has been minimized.

Show comment
Hide comment
@JeffZhang02747

JeffZhang02747 Jul 9, 2016

Contributor

sure, just updated readme

Contributor

JeffZhang02747 commented Jul 9, 2016

sure, just updated readme

@taisel

This comment has been minimized.

Show comment
Hide comment
@taisel

taisel Jul 10, 2016

Owner

I think we need to rewrite the readme entirely. Still gonna use that BSD license message of course though. The readme as a whole is ancient and we should form a separate pull for it.

Owner

taisel commented Jul 10, 2016

I think we need to rewrite the readme entirely. Still gonna use that BSD license message of course though. The readme as a whole is ancient and we should form a separate pull for it.

@taisel taisel merged commit a8b4fce into taisel:master Jul 10, 2016

@taisel

This comment has been minimized.

Show comment
Hide comment
@taisel

taisel Jul 10, 2016

Owner

For all those who have old forks of IodineGBA: Yes, it hasn't been GPL for a few months now. It's BSD licensed.

Owner

taisel commented Jul 10, 2016

For all those who have old forks of IodineGBA: Yes, it hasn't been GPL for a few months now. It's BSD licensed.

@taisel

This comment has been minimized.

Show comment
Hide comment
@taisel

taisel Jul 10, 2016

Owner

After re-adding a missing object 51541f9 it works... but barely.

Took 10 minutes to get Google Chrome to register a button press once.

Owner

taisel commented Jul 10, 2016

After re-adding a missing object 51541f9 it works... but barely.

Took 10 minutes to get Google Chrome to register a button press once.

@taisel

This comment has been minimized.

Show comment
Hide comment
@taisel

taisel Jul 10, 2016

Owner

It's in a state that's not affecting the emulator itself, so we can leave it in. Send in new commits to polish the voice feature if you want.

Owner

taisel commented Jul 10, 2016

It's in a state that's not affecting the emulator itself, so we can leave it in. Send in new commits to polish the voice feature if you want.

@JeffZhang02747

This comment has been minimized.

Show comment
Hide comment
@JeffZhang02747

JeffZhang02747 Jul 13, 2016

Contributor

Did you test the voice with the gameplay background music on or with earphone?
One reason why taking 10 minutes to register a button press might be the webkitSpeechRecognition do not do echo cancellation to filter out noise.

https://docs.google.com/document/d/1QRajFwBdV82aTnPCQNKOfL2ZGkyfG9X9ZfCYgK2xstk/edit?pref=2&pli=1

Contributor

JeffZhang02747 commented Jul 13, 2016

Did you test the voice with the gameplay background music on or with earphone?
One reason why taking 10 minutes to register a button press might be the webkitSpeechRecognition do not do echo cancellation to filter out noise.

https://docs.google.com/document/d/1QRajFwBdV82aTnPCQNKOfL2ZGkyfG9X9ZfCYgK2xstk/edit?pref=2&pli=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment