Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRewritten CSS #38
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Daniel-Griffiths
Aug 23, 2016
Contributor
Let me know if there are any issue and I will go ahead and fix them. I preserved all the existing id's so all the js stuff should still be working fine. :)
|
Let me know if there are any issue and I will go ahead and fix them. I preserved all the existing id's so all the js stuff should still be working fine. :) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
taisel
Aug 26, 2016
Owner
Thanks for modifying the CSS. I haven't spent a lot of time on this project lately and have been busy irl. Hopefully I'll check this at some point soon.
|
Thanks for modifying the CSS. I haven't spent a lot of time on this project lately and have been busy irl. Hopefully I'll check this at some point soon. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Daniel-Griffiths
Sep 5, 2016
Contributor
No worries! I also started working on some mobile controls, but I am not sure if its really needed. Does the emulator work in any mobile browsers?
|
No worries! I also started working on some mobile controls, but I am not sure if its really needed. Does the emulator work in any mobile browsers? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
taisel
Sep 5, 2016
Owner
It works in iOS 7 and iOS 10 beta but NOT iOS 8 or 9 due to a WebKit JavaScriptCore bug.
Aka "this website has encountered an error and has been reloaded" catch all error message.
This was fixed in the latest iOS beta and newer JSC does run it considerably faster than last year's JSC.
That means you only need to target iPhone 5 and up, as the 4S isn't getting iOS 10 IIRC.
|
It works in iOS 7 and iOS 10 beta but NOT iOS 8 or 9 due to a WebKit JavaScriptCore bug. Aka "this website has encountered an error and has been reloaded" catch all error message. That means you only need to target iPhone 5 and up, as the 4S isn't getting iOS 10 IIRC. |
taisel
merged commit dbcf50d
into
taisel:master
Sep 20, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
taisel
Sep 20, 2016
Owner
We'll connect the eventing to the buttons shortly, just wanted to push it to master the layout logic. Mobile still needs the new xaudiojs which hasn't come yet.
|
We'll connect the eventing to the buttons shortly, just wanted to push it to master the layout logic. Mobile still needs the new xaudiojs which hasn't come yet. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
taisel
Sep 21, 2016
Owner
Canvas needed that absolutely positioned container to define a width/height to resize against properly.
|
Canvas needed that absolutely positioned container to define a width/height to resize against properly. |
Daniel-Griffiths commentedAug 23, 2016
No description provided.