Code Standards: I see an evil eval #14

Closed
taitems opened this Issue May 31, 2012 · 3 comments

Projects

None yet

4 participants

@taitems
Owner
taitems commented May 31, 2012

There's a dirty, dirty eval in the script now.

@lp344
lp344 commented May 31, 2012

i see it, too :-)

var date = eval("new" + dateStr.replace(///g, " "));

shouldn't be neccessary, anyhow...

@sunnywalker

JSHint also complains about all the string concatenation lines broken by new lines at the +. "Bad line breaking before '+'." Not as evil as eval though.

@usmonster
Collaborator

Fixed in ebf84ca.

@usmonster usmonster closed this Jul 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment